Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add health and readiness endpoints + probe config #556

Merged
merged 3 commits into from
Nov 18, 2020

Conversation

aslakknutsen
Copy link
Member

@aslakknutsen aslakknutsen commented Nov 13, 2020

Leader election can take a few more seconds so ensure
readiness is not done until leader election is done.

Related to #528
Fixes #546
Fixes #547

@aslakknutsen aslakknutsen added component/operator Component: Operator service kind/enhancement Kind: New feature or improvement labels Nov 13, 2020
Copy link
Contributor

@bartoszmajsak bartoszmajsak left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One tiny suggestion from my side.

pkg/cmd/serve/serve.go Outdated Show resolved Hide resolved
Leader election can take a few more seconds so ensure
readiness is not done until leader election is done.

Related to #528
Fixes #546
Fixes #547
@bartoszmajsak bartoszmajsak merged commit 86efdcd into master Nov 18, 2020
@bartoszmajsak bartoszmajsak deleted the readyness branch November 18, 2020 19:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
component/operator Component: Operator service kind/enhancement Kind: New feature or improvement
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add readiness check to istio-workspace controller Add health check to istio-workspace controller
2 participants