-
Notifications
You must be signed in to change notification settings - Fork 7
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Updated notifier breaks maizzle build
in monorepos.
#198
Comments
@cossssmin any input on this? I can submit a PR adding the try catch back... Also you could use This is currently blocking me in production as I can't run my build scripts without editing the index.js file directly. |
Hey Josh, sorry for the delay, busy times... Yes, please open a PR and we take it from there, thank you! |
No worries, big fan of maizzle, thank you for what you've already done. I've opened a PR #200 |
Thanks Josh, released 1.5.3: https://github.com/maizzle/cli/releases/tag/v1.5.3 |
Sorry need to reopen this and revert the change, it's breaking Maizzle right now... |
Error stack ref:
|
This is an issue when running the Maizzle CLI globally. So if you have installed it with Running the NPM scripts, like You can pin Most probably we'll need a try/catch and fall back to the old way, but I'm open to suggestions :) |
Oh interesting, I haven't ran a cli from global scope in a long time. I'll see if I can come up with a solution but for now pin to 1.5.3. |
Hi @joshmanders, can you try the Used |
Yes I will try it later this afternoon when I get back to my desk and report back. Thank you! |
@cossssmin works perfectly! |
Sweet! Will release it next week since I’ll be away for Easter here 👍 |
I can stay on the old version that worked until you release so no worries. Have a happy easter! |
Published v1.5.5, give it a try and let me know how it goes 👍 https://github.com/maizzle/cli/releases/tag/v1.5.5 |
I've had no issues before but haven't updated in a while, being as we're still on
v4
I just wholesale updated from4.0.2
to4.4.4
and nowmaizzle build --bin ....
breaks becauseupdateNotifier
doesn't take the--bin
flag into consideration, it still looks for./node_modules
which doesn't exist in many monorepos.Looks like this issue was brought in here: 847d7f3
The text was updated successfully, but these errors were encountered: