Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: remove update-notifier #237

Closed
wants to merge 3 commits into from
Closed

Conversation

cossssmin
Copy link
Member

@cossssmin cossssmin commented Mar 27, 2024

This PR:

  • removes the update-notifier dependency
  • replaces xo with eslint

update-notifier was causing all sorts of issues and it had a security vulnerability which was only fixed in a version we can't update to currently, because it's ESM-only.

Closes #198
Closes #204
Closes #236

@benjamin-chang
Copy link

I was able to reproduce this error locally (node: v14.21.3, npm: 6.14.18).

Regenerating the package-lock.json fixes it.

@cossssmin cossssmin closed this Apr 8, 2024
@cossssmin cossssmin deleted the remove-update-notifier branch June 17, 2024 15:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
2 participants