Merge pull request #1316 from Jordinateur/patch-1

maizzle · Jul 30, 2024 · 239e4c9 · 239e4c9
2 parents b62c762 + 5d7acea
commit 239e4c9
Show file tree

Hide file tree

Showing 2 changed files with 4 additions and 7 deletions.
diff --git a/src/transformers/replaceStrings.js b/src/transformers/replaceStrings.js
@@ -6,8 +6,6 @@ import { parser as parse } from 'posthtml-parser'
 import posthtmlConfig from '../posthtml/defaultConfig.js'
 import defaultPostHTMLConfig from '../posthtml/defaultConfig.js'
 
-const captureRegex = /\$\d/gi
-
 const posthtmlPlugin = (replacements = {}) => tree => {
   if (!isEmpty(replacements)) {
     const regexes = Object.entries(replacements).map(([k, v]) => [new RegExp(k, 'gi'), v])
@@ -17,13 +15,11 @@ const posthtmlPlugin = (replacements = {}) => tree => {
       render(tree).replace(patterns, matched => {
         for (const [regex, replacement] of regexes) {
           if (regex.test(matched)) {
-            if (captureRegex.test(replacement)) {
-              return matched.replace(regex, replacement)
-            }
-
-            return replacement
+            return matched.replace(regex, replacement)
           }
         }
+
+        return matched
       }),
       defaultPostHTMLConfig
     )

diff --git a/test/transformers.test.js b/test/transformers.test.js
@@ -582,6 +582,7 @@ describe.concurrent('Transformers', () => {
     expect(await replaceStrings('initial text', { '/not/': 'found' })).toBe('initial text')
     expect(await replaceStrings('initial text', { 'initial': 'updated' })).toBe('updated text')
     expect(await replaceStrings('initial [text]', { '(initial) \\[(text)\\]': '($2) updated' })).toBe('(text) updated')
+    expect(await replaceStrings('«initial» «text»', { '«(.*?)»' : '«&nbsp;$1&nbsp;»' })).toBe('«&nbsp;initial&nbsp;» «&nbsp;text&nbsp;»')
 
     expect(
       await useTransformers('initial text', { replaceStrings: { 'initial': 'updated' } }).then(({ html }) => html)