Skip to content
This repository has been archived by the owner on Oct 25, 2022. It is now read-only.

Display actual errors from jobs when any #183

Merged
merged 1 commit into from
May 15, 2019

Conversation

Thilas
Copy link
Collaborator

@Thilas Thilas commented May 14, 2019

@majkinetor, I just noticed that when running updateall script we never get the actual errors from the powershell jobs running update scripts. Here is a change that aims at fixing this behavior.

FYI, I basically applied the solution from https://stackoverflow.com/questions/8751187/how-to-capture-the-exception-raised-in-the-scriptblock-of-start-job

Any thoughts?

@majkinetor
Copy link
Owner

That is regression explained here: #181

Will need to check it out, in that part of code subtle errors can creep in...

@majkinetor
Copy link
Owner

I left this unsolved because I wanted to understand why did this happen with that change in #181. I did read the code many times and tested various versions but still not sure why ... throwing is obviously solution instead of return but that part of code worked before .... When I revert #181 it works again...

@majkinetor majkinetor merged commit d09a94f into majkinetor:master May 15, 2019
@majkinetor
Copy link
Owner

Looks OK, lets merge and check out tests.

@Thilas
Copy link
Collaborator Author

Thilas commented May 15, 2019

Thanks! Let me know if you see anything wrong with this. I'll have a look.

@Thilas Thilas deleted the updateall-errors branch May 15, 2019 20:19
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants