Skip to content
This repository has been archived by the owner on Oct 25, 2022. It is now read-only.

fix sourcing #214

Merged
merged 1 commit into from
Aug 18, 2020
Merged

fix sourcing #214

merged 1 commit into from
Aug 18, 2020

Conversation

jetersen
Copy link
Contributor

@jetersen jetersen commented Aug 17, 2020

in newer version of Windows PowerShell the . $_ does not actually source the files.

Chose to expand aliases as well.

Instead what happens is powershell will echo the get-childitem to terminal:

> $PSVersionTable.PSVersion                                                                                             
Major  Minor  Build  Revision
-----  -----  -----  --------
5      1      19041  1

> Import-Module au

   Directory: C:\Users\joseph\Documents\PowerShell\Modules\AU\2019.5.22\Private

AUPackage.ps1    AUVersion.ps1    check_url.ps1    is_url.ps1       is_version.ps1   request.ps1

   Directory: C:\Users\joseph\Documents\PowerShell\Modules\AU\2019.5.22\Public

Get-AUPackages.ps1                      Get-RemoteChecksum.ps1                  Get-RemoteFiles.ps1
Get-Version.ps1                         Push-Package.ps1                        Set-DescriptionFromReadme.ps1
Test-Package.ps1                        Update-AUPackages.ps1                   Update-Package.ps1

@majkinetor majkinetor merged commit e87d67c into majkinetor:master Aug 18, 2020
@jetersen jetersen deleted the patch-1 branch August 18, 2020 06:34
@jetersen
Copy link
Contributor Author

@majkinetor thanks for merging, also thanks for fixing the build 😅

@majkinetor
Copy link
Owner

No problem. Do you have any link with more information about this pwsh change ?

@jetersen
Copy link
Contributor Author

jetersen commented Aug 18, 2020

this was not a pwsh change 😅 I was using PowerShell 5 as you can see in snippet I gave.

Yes it is a newer build as it matches closely with OS build I am currently on Windows 10 20H2 19042.450 not sure if Windows PowerShell has an official changelog.

> $PSVersionTable.PSVersion                                                                                             
Major  Minor  Build  Revision
-----  -----  -----  --------
5      1      19041  1

@majkinetor
Copy link
Owner

Not sure if that was really so, but who cares, if it works for you now.

Such a major breaking change would without even minor version update is suspicious.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants