Skip to content
This repository has been archived by the owner on Oct 25, 2022. It is now read-only.

Set back the tls support and solve Issues #206 #216

Merged
merged 1 commit into from
Aug 18, 2020
Merged

Set back the tls support and solve Issues #206 #216

merged 1 commit into from
Aug 18, 2020

Conversation

tunisiano187
Copy link
Contributor

@tunisiano187 tunisiano187 commented Aug 18, 2020


This change is Reviewable

@tunisiano187 tunisiano187 changed the title Set back the tls support Set back the tls support and solve Issues #206 Aug 18, 2020
@tunisiano187
Copy link
Contributor Author

Solve correctly the issue #206

@majkinetor majkinetor merged commit 9c0ba43 into majkinetor:master Aug 18, 2020
@tunisiano187 tunisiano187 deleted the patch-1 branch August 18, 2020 19:49
@matthewprenger
Copy link
Contributor

matthewprenger commented Oct 11, 2020

Edit: Installing .NET 4.8, even though PowerShell doesn't use it, allows for the Tls13 value to be resolved.

It looks like this breaks compatibility with at least Server 2016 since Tls13 isn't present in the SecurityProtocolType enum. Will have to look into how to support 1.3 in a backwards compatible manor.

PS C:\> [System.Environment]::OSVersion.Version

Major  Minor  Build  Revision
-----  -----  -----  --------
10     0      14393  0


PS C:\> $PSVersionTable

Name                           Value
----                           -----
PSVersion                      5.1.14393.3866
PSEdition                      Desktop
PSCompatibleVersions           {1.0, 2.0, 3.0, 4.0...}
BuildVersion                   10.0.14393.3866
CLRVersion                     4.0.30319.42000
WSManStackVersion              3.0
PSRemotingProtocolVersion      2.3
SerializationVersion           1.1.0.1


PS C:\> [System.Net.ServicePointManager]::SecurityProtocol = 'Tls,Tls11,Tls12,Tls13'
Exception setting "SecurityProtocol": "Cannot convert value "Tls,Tls11,Tls12,Tls13" to type "System.Net.SecurityProtocolType". Error: "Unable to match the identifier name Tls,Tls11,Tls12,Tls13 to a valid
enumerator name. Specify one of the following enumerator names and try again:
SystemDefault, Ssl3, Tls, Tls11, Tls12""
At line:1 char:1
+ [System.Net.ServicePointManager]::SecurityProtocol = 'Tls,Tls11,Tls12 ...
+ ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
    + CategoryInfo          : NotSpecified: (:) [], SetValueInvocationException
    + FullyQualifiedErrorId : ExceptionWhenSetting

PS C:\> [System.Net.ServicePointManager]::SecurityProtocol = 'Tls,Tls11,Tls12'
PS C:\> [System.Net.ServicePointManager]::SecurityProtocol
Tls, Tls11, Tls12

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants