This repository has been archived by the owner on Oct 25, 2022. It is now read-only.
Refresh options headers downloading multiple files #219
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Headers defined in options are injected into the WebClient instance used to download files. This is done to support downloading files where headers are required eg. REFERRER. The headers can be defined and injected via $Latest.Options.Headers. The headers are cleared when a download is performed with DownloadFile so where multiple files are downlaoded the headers are not available for the second download. This impacts when a package requries both 32-bit and 64-bit files to be downloaded during package construction. To address this the headers should be injected prior to each download to ensure that they are available.
|
Thanks @dgalbraith |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Headers defined in options are injected into the WebClient instance used to
download files. This is done to support downloading files where headers
are required eg. Referrer. The headers can be defined and injected via
$Latest.Options.Headers.
The headers are cleared when a download is performed with DownloadFile
so where multiple files are downlaoded the headers are not available for
the second download. This impacts when a package requries both 32-bit
and 64-bit files to be downloaded during package construction.
To address this the headers should be injected prior to each download to
ensure that they are available.
Resolves #218