Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Missing password is not recognized #412

Closed
danielmarschall opened this issue Nov 20, 2018 · 6 comments
Closed

Missing password is not recognized #412

danielmarschall opened this issue Nov 20, 2018 · 6 comments

Comments

@danielmarschall
Copy link

I have the latest version 1.7.13 running on Maria DB 10.1.26-MariaDB-0+deb9u1 .
I noticed that it did not recognize that I have a user which has no password set.
The reason is that the following line of code presents a string "password" rather than the field "password". So the later checks is null and = '' always succeed.

Here is a fix that works for me:

Find:
"IF(plugin='mysql_native_password', authentication_string, 'password')";

Replace with:
"IF(plugin='mysql_native_password', authentication_string, password)";

@plutocrat
Copy link

plutocrat commented Nov 21, 2018

Didn't work for me. Edited line 1726 to remove the '' around password and still got the same error.
As far as I can gather, if plugin is set to mysql_native_password, then it should only be looking in the Password field.

I fiddled around with things and this seemed to work:

if ( $myvar{'version'} =~ /5\.7|10\..*MariaDB*/ ) { $PASS_COLUMN_NAME = "IF(plugin='mysql_native_password', 'authentication_string', 'password')"; }
[OK] All database users have passwords assigned

@StKox
Copy link

StKox commented Mar 6, 2019

Still open in 1.7.14. I can confirm daniels post. Removing the two apostrophes surrounding 'password' is working well.

@jmrenouard
Copy link
Collaborator

Modifications made

@tholu
Copy link

tholu commented Mar 11, 2019

This change breaks the fix for #373 (ff2a47e), see also #427.

@jmrenouard
Copy link
Collaborator

Tested and improved on last version.
Don't face any issue with last version.

@jmrenouard
Copy link
Collaborator

It's ok for me now.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

5 participants