Add support for Ruby 3.4 #23
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
makmic
force-pushed
the
ml/add-ruby-3-4-support
branch
from
990a7b0 to
193abdb
Compare
makmic
force-pushed
the
ml/add-ruby-3-4-support
branch
from
193abdb to
ccc61c0
Compare
dastra-mak
approved these changes
Jan 16, 2025
There was a problem hiding this comment.
Thanks for the PR! @mak-dunkelziffer wanted to add this to #22
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I ran into this issue while trying to add Ruby 3.4 Support for another gem:
It turns out that
mutex_mand a few other gems are no longer standard gems in Ruby 3.4 but indirect dependencies of Rails < 8. It's only a problem in tests, but I fixed it for the gemika test suite as well.