Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(account_billing_alert): fix deprecated threshold #24

Merged
merged 1 commit into from
Aug 7, 2024

Conversation

vsnunes
Copy link
Contributor

@vsnunes vsnunes commented Jul 25, 2024

Hi all,

When using account_billing_alert module with a more recent version of AWS provider, the parameter threshold in the resource aws_ce_anomaly_subscription is no longer available.

threshold was deprecated on version 4.51.0 with their pull request and replaced by threshold_expression.

@RubenMakandra RubenMakandra self-assigned this Aug 7, 2024
@RubenMakandra
Copy link
Contributor

Hi @vsnunes,
thanks for making the pull request.

Would it be possible to run pre-commit on your branch locally? This will automatically update the documentation, and fix the failed pre-commit action here.

@vsnunes
Copy link
Contributor Author

vsnunes commented Aug 7, 2024

Hi @RubenMakandra
Thanks for the reply.

I updated the commit to include the changes generated after running the pre-commit.

@RubenMakandra RubenMakandra merged commit b2cc3cd into makandra:main Aug 7, 2024
8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants