Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fan turn_on should support setting preset_mode and percentage at the same time #1381

Closed
make-all opened this issue Dec 7, 2023 · 0 comments
Closed

Fan turn_on should support setting preset_mode and percentage at the same time #1381

make-all opened this issue Dec 7, 2023 · 0 comments

Comments

@make-all
Copy link
Owner

make-all commented Dec 7, 2023

As discovered with #1380 (beginning with discussion #1379), the fan API was changed some time ago to allow setting percentage and preset_mode in the turn_on service. As of 2023.12.1 we now support the new API, but do not do anything with the additional arguments.

The arguments should be combined into a single tuya protocol message and sent to the device, similar to what is done with light.turn_on.
@make-all make-all added the enhancement New feature or request label Dec 7, 2023
make-all added a commit that referenced this issue Dec 7, 2023
@make-all
Fan: use percentage and preset_mode arguments to turn_on.
2c71e28 
When arguments are given, use them.

Issue #1381
@make-all make-all added awaiting confirmation Wating for confirmation the issue is solved unreleased Will be in next release labels Dec 7, 2023
@make-all make-all removed enhancement New feature or request awaiting confirmation Wating for confirmation the issue is solved unreleased Will be in next release labels Dec 31, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
Tuya Local
Archived in project
Milestone
No milestone
Development

No branches or pull requests
1 participant
@make-all