Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Identical devices get detected as different types #1959

Closed
novanarwhal opened this issue May 28, 2024 · 14 comments
Closed

Identical devices get detected as different types #1959

novanarwhal opened this issue May 28, 2024 · 14 comments

Comments

@novanarwhal
Copy link

novanarwhal commented May 28, 2024

Describe the bug
I am adding 8 fans (detected as Skyfan DC fans). Two of the devices are being detected as a light.
To Reproduce
Adding the fan using the cloud assisted configuration

Expected behavior
All fans to be added as Skyfan DC fans.

Additional context
Attached diagnostics from correct and incorrectly detected fans.

Is there any way to manually edit devices using the configuration from a correct fan into the incorrect fan?

Screenshot 2024-05-28 113822
tuya_local-2bc2c9e9f69fb1fd99fcdee686405e8b-Guest fan-6c5aad47d776fb3b90314cb93661ebd9.json
tuya_local-5e2146fc35846b11c844e35c96a514f9-RGBCW light rumpus-8c9d7023e1eb944b874a5314c7f8890e.json
Screenshot 2024-05-28 115131

@novanarwhal novanarwhal added the bug Something isn't working label May 28, 2024
@make-all
Copy link
Owner

Changing the device type after installation changes the entities which are present, messing up the entity registry. So the only supported way to do it is to remove and re-add the device.

@make-all make-all added device improvement Improvement to an existing device config and removed bug Something isn't working labels May 28, 2024
@make-all
Copy link
Owner

You should have been offered the fan config when you installed the devices. It seems you just clicked through with the default option selected without checking it first.

@make-all make-all closed this as not planned Won't fix, can't repro, duplicate, stale May 28, 2024
@make-all make-all removed the device improvement Improvement to an existing device config label May 28, 2024
@make-all make-all reopened this May 28, 2024
@make-all make-all added the device improvement Improvement to an existing device config label May 28, 2024
@novanarwhal
Copy link
Author

You should have been offered the fan config when you installed the devices. It seems you just clicked through with the default option selected without checking it first.
Screenshot 2024-05-28 115131

This is the option list provided when trying to setup the problem fans. No fan option available.

@make-all
Copy link
Owner

Sorry, I read these configs the wrong way around, thinking that the misdetected one had an extra dp, when it was actually a missing dp for the preset.

@novanarwhal
Copy link
Author

You should have been offered the fan config when you installed the devices. It seems you just clicked through with the default option selected without checking it first.
Screenshot 2024-05-28 115131

This is the option list provided when trying to setup the problem fans. No fan option available.

For reference this is one that detects properly.
Screenshot 2024-05-28 115519

@novanarwhal
Copy link
Author

Thanks for looking in at this. Anyway to temporarily address this or edit it before a fix flows through?

@make-all
Copy link
Owner

Add optional: true to the preset_mode dp config.

@novanarwhal
Copy link
Author

Add optional: true to the preset_mode dp config.

I do apologise - you have blown right past my level of knowledge here. Can you tell me where I go to add this or point to a guide?

@make-all
Copy link
Owner

Find the file skyfan_dc_fan.yaml. In that file, search for preset_mode. On the line after that, add a new line with same indentation that says optional: true

@novanarwhal
Copy link
Author

Screenshot 2024-05-28 171343

Unfortunately this change does not enable me to chose the fan option at the setup stage.

@novanarwhal
Copy link
Author

I have managed to get it work. I added the optional line to a different dps section and it started getting detected.
Screenshot 2024-05-28 173026

Thank you for your help.

make-all added a commit that referenced this issue May 28, 2024
@make-all
Copy link
Owner

Strange. The device must randomly fail to report either speed or preset (maybe depending on which was last used).

@make-all make-all added awaiting confirmation Wating for confirmation the issue is solved unreleased Will be in next release and removed awaiting confirmation Wating for confirmation the issue is solved labels May 28, 2024
@novanarwhal
Copy link
Author

novanarwhal commented May 28, 2024 via email

@novanarwhal
Copy link
Author

Strange. The device must randomly fail to report either speed or preset (maybe depending on which was last used).

I played a bit more. It would seem that it entirely depends on when it was last used. I removed the optional: true line from the yaml and then turned a fan on (via remote, not isolator), set a speed and a timer that previously didnt work with tuya-local and all of a sudden it started getting detected correctly.

So the best solution to this problem is ensure that the device has been activated and certain functions used.

@make-all make-all removed unreleased Will be in next release device improvement Improvement to an existing device config labels Jun 9, 2024
@make-all make-all closed this as completed Jun 9, 2024
timlaing pushed a commit to timlaing/tuya-local that referenced this issue Aug 8, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Archived in project
Development

No branches or pull requests

2 participants