Aleco Air fault sensors #1232
Merged
Aleco Air fault sensors #1232
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
make-all
reviewed
Nov 1, 2023
| mapping: | ||
| - dps_val: 0 | ||
| value: OK | ||
| icon: "mdi:cup-outline" |
There was a problem hiding this comment.
Don't set the icon for the OK case. If the status is OK, you want the preset icons showing through.
| - entity: binary_sensor | ||
| class: problem | ||
| name: Fault | ||
| icon: "mdi:engine-off-outline" |
There was a problem hiding this comment.
I don't think this icon is a substantial improvement over the default icon for problem sensors, so I think it is better to leave it off.
- remove unneeded icons - remove optional marking that is in the wrong place
|
Sorry, I was away for a month and didn't have time to make the suggested changes. Thank you for merging the PR and adding your requested changes as well. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#1199 (reply in thread)