New device - Akai Heat Pump Dryer #1266
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
make-all
reviewed
Nov 12, 2023
| - dps_val: "Sportswear" | ||
| value: "Sportswear" | ||
| - entity: select | ||
| class: enum |
There was a problem hiding this comment.
select entity does not have an enum class
| name: button # start | ||
| type: boolean | ||
| - entity: select | ||
| class: enum |
There was a problem hiding this comment.
select entity does not have an enum class.
| - id: 103 | ||
| name: switch # anti_crease | ||
| type: boolean | ||
| - entity: switch |
There was a problem hiding this comment.
Maybe better as a lock entity (similar to child locks)
| - id: 4 | ||
| name: sensor # drying_time_left | ||
| type: integer | ||
| unit: min |
There was a problem hiding this comment.
There should be a newline at the end of the file. I'm not sure if the yaml parser built into Home Assistant requires it, but in general it will avoid issues with the last line not being properly parsed, which is why the POSIX standard specifies that text files should end in a newline, and most language definitions follow that even if the compilers and interpreters are lenient on that point.
- remove unsupported class from select entities - add duration class to time sensors - add icons to entities - naming convention changes, clarification
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I can't find an example of a Dryer entity anywhere (neither in HASS or this project), so hopefully the way I've set this device up makes sense.
The modes can be selected and the device can be started.
UX doesn't feel quite right - i feel like selecting a drying mode should fire off the 'start' DP (unless the selected mode is 'off').
Fixes #1265