-
Notifications
You must be signed in to change notification settings - Fork 526
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
add support for VALEHAUS SYZN119 towel warmer #1328
Conversation
There is one thing I have no idea how to fix yet, this device has a count_down dp 12, it's an enum, I map it into homeassistant's select entity, however when I change count_down time to eg 6h, it's still reporting dp 12 with status "cancel" not newly configured "6h".
this result in that, when I try to set countdown from homeassistant ui, it will result in unkown, after a while. |
You may need to observe the dp when you make changes from the app to see if the values match the dps mapping info you have above. If this information is not from the QueryThingsDataModel cloud API call, you may also get more accurate information from that. |
I select different values from the enum within Tuya app, and immediate query the latest status data from IOT webpage, the latest value is not the one I selected, it's just always "cancel". |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This device seems like it should be a climate entity, with two timer related secondary entities.
power = hvac_mode (true = heat, false = "off")
temp_set = temperature
temp_current = current_temperature
work_mode = hvac_action (standby = idle, heating = heating / swapped if that is really a bug in the device)
For the Timer issue, as long as "Time remaining" updates when the timer is set, it should be enough feedback.
custom_components/tuya_local/devices/valehaus_syzn119_tow_w.yaml
Outdated
Show resolved
Hide resolved
max: 99 | ||
unit: "℃" | ||
- entity: select | ||
name: countdown_set |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Suggested name is "Timer", to be consistent with other devices.
- dps_val: "6h" | ||
value: "6h" | ||
- entity: sensor | ||
name: countdown_left |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Suggested name is "Time remaining" to be consistent with other devices.
Need feedback on the swapped standby and heating, other issues are minor, which I would fix myself, but I am not sure whether the swapped mapping is intentional, or a mistake. |
Yes, the swap is intentional, it's a device bug. I have this device myself. |
- Pull most of the functionaity into a climate entity. - standardise naming. PR make-all#1328
1d93237
to
665d422
Compare
- Pull most of the functionaity into a climate entity. - standardise naming. PR #1328
name: VALEHAUS Towel Warmer
products:
name: VALEHAUS SYZN119
VALEHAUS SYZN119 DPS
self test