Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Thermoval TVT 40 WiFi Thermostat #1421

Merged
merged 4 commits into from
Sep 2, 2024
Merged

Conversation

madpeteguy
Copy link
Contributor

- id: 9
name: hvac_mode
type: boolean
readonly: true
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

hvac_mode should not be read-only. If this is really read-only, rename this attribute (I guess the original tuya name is work_mode, which would be appropriate) to avoid buttons that cannot be used in the UI (the mode will then always show as auto).

@madpeteguy
Copy link
Contributor Author

@make-all Thanks for review!

It's been six months since I created this configuration, I've forgotten a lot. 🤯
But I got tired of catching up with own configuration file after each plugin update, although I could mount it via docker.
I'll check with the suggestions when I find some free time, probably after the new year.

Anyway, it's based on another device's configuration that someone provided somewhere as a workaround, but I can't find that entry. The replacement worked fine with the basic functionality of the thermostat.
I upgraded it a bit to make most of the functionality of the TVT 40 device available in HA.
Mainly displaying cooling mode (without hacks like overriding hvac_mode it always displayed heating, if i remember correctly it had problems with writing to id:9 so read only seemed right).
Also temperature reading for sensor_select = "2" with limits for both sensors, where one has a common weekly schedule in auto mode or a fixed value in manual mode, and a separate value for the other sensor.

Thermostate cards do not support such a combo, I'm fine with apexchart:
obraz
It is controlled with entities card (i think it might be the reason for sensor duplication):
obraz

Thermostate card hide so much info...
obraz

Copy link
Owner

@make-all make-all left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fixed most review comments

Apply most of the review comments.
PR make-all#1421
@make-all make-all marked this pull request as ready for review September 2, 2024 13:34
This seems to be a requirement of HA now.
@make-all make-all merged commit e212a08 into make-all:main Sep 2, 2024
4 checks passed
make-all added a commit that referenced this pull request Sep 2, 2024
Apply most of the review comments.
PR #1421
make-all added a commit that referenced this pull request Sep 2, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

2 participants