Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for Eeese Anna dehumidifier #1450

Closed
wants to merge 4 commits into from

Conversation

sevimuelli
Copy link
Contributor

Based on the existing Eeese dehumidifiers, but needed a separate one to be recognised.

For some reason, my VS Code formatted the Acknowledgements.md, but only corrected some typos.

@sevimuelli
Copy link
Contributor Author

There is one error: FAILED tests/test_device_config.py::TestDeviceConfig::test_config_files_parse - AssertionError: False is not true : eeese_anna_dehumidifier.yaml missing required sensor in binary_sensor_tank,

I expect the problem to be that I changed the name from sensor to fault_code also in the secondary entities. Does it need to be "sensor" or does it only have to be unique?

secondary_entities:
  - entity: binary_sensor
    name: Tank
    class: problem
    category: diagnostic
    dps:
      - id: 19
        type: bitfield
        name: fault_code
        optional: true
        mapping:
          - dps_val: 4
            value: true
          - value: false
  - entity: binary_sensor
    name: Defrost
    class: problem
    category: diagnostic
    dps:
      - id: 19
        type: bitfield
        name: fault_code
        optional: true
        mapping:
          - dps_val: 8
            value: true
          - value: false
  - entity: binary_sensor
    name: Fault
    class: problem
    category: diagnostic
    dps:
      - id: 19
        type: bitfield
        name: fault_code
        optional: true
        mapping:
          - dps_val: 0
            value: false
          - dps_val: null
            value: false
          - dps_val: 4
            value: false
          - dps_val: 8
            value: false
          - value: true

Can you please tell me what I need to do here?

@make-all
Copy link
Owner

binary_sensor requires a dp named sensor, which will be the value of the sensor. The name does not need to be the same when the dp is listed in multiple entities, so the same id can be listed as fault_code in the humidifier entity to make the raw value available as an extra attribute there, and also listed as the sensor dp of the binary_sensor entity.

@sevimuelli
Copy link
Contributor Author

Ok I understand. Thank you for your help

@make-all
Copy link
Owner

Merged manually to workaround the conflict in doc file

@make-all make-all closed this Dec 27, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

2 participants