Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix returning supported color modes #1633

Closed
wants to merge 1 commit into from

Conversation

hyperb1iss
Copy link

  • Return a set including ColorMode.ONOFF instead of a list

 * Return a set including ColorMode.ONOFF instead of a list
make-all added a commit that referenced this pull request Feb 9, 2024
This is now enforced in HA 2024.2.

Issue #1631 (simplified version of PR #1633)
@make-all
Copy link
Owner

make-all commented Feb 9, 2024

Thanks for the effort of submitting a fix.
I've installed a slightly simpler version of the change which only changes the lists to sets without altering the logic.
ONOFF is actually handled already for the devices that support on/off and nothing else. The fallback empty set should not actually be used by any real devices, as it represents a light with no controls.

@make-all make-all closed this Feb 9, 2024
timlaing pushed a commit to timlaing/tuya-local that referenced this pull request Aug 8, 2024
This is now enforced in HA 2024.2.

Issue make-all#1631 (simplified version of PR make-all#1633)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants