add LightStar track light #1700
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
make-all
reviewed
Mar 4, 2024
| range: | ||
| min: 5 | ||
| max: 1000 | ||
| mapping: |
There was a problem hiding this comment.
No scale is needed on brightness now
- add CCT to the name, to differentiate from dimming only bulbs - remove scale from brightness, as this is now auto-scaled - use a single default mapping for color_temp - follow convention of lower case only for attribute names, and avoid "id" as it may clash with standard attributes in future.
make-all
added a commit
that referenced
this pull request
Mar 4, 2024
timlaing
pushed a commit
to timlaing/tuya-local
that referenced
this pull request
Aug 8, 2024
Issue make-all#1699, reduced function version of PR make-all#1702 - docs for recent PRs make-all#1696, make-all#1700, make-all#1702
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.