-
Notifications
You must be signed in to change notification settings - Fork 526
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Added device file for Multi Leaf DY-107 Thermostat #1718
Conversation
? |
The |
@@ -0,0 +1,196 @@ | |||
name: Multi-leaf DY-107 thermostat |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Make this top level name generic (just "Thermostat" for example), as there may be other products that it matches.
min: -9 | ||
max: 9 | ||
- entity: switch | ||
name: Anti-frost |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
use translation_key: anti_frost
here instead of name and icon, to make use of the new icon translations and name translation in latest release.
type: boolean | ||
name: switch | ||
- entity: lock | ||
name: Child lock |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Use translation_key: child_lock
here instead of name and the icon mappings below to make use of translations.
icon: "mdi:thermometer" | ||
value: Both | ||
- entity: binary_sensor | ||
name: Error |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Remove this name, and use the standard "problem" class translations from Home Assistant.
value: false | ||
- value: true | ||
- entity: number | ||
name: High temperature limit |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Usually I would use "High temperature limit" for an alarm point. Since this is setting the maximum for the temperature adjustment, I would use "Maximum temperature" here. Similarly for "Minimum temperature" below.
value: "7 days" | ||
- dps_val: null | ||
value_redirect: alt | ||
- entity: number |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Make this a light entity, with just a brightness
dp below.
Suggested changes - naming - use of existing translation_keys - use of light entity
First of all, thank you for your hard work!
I created a config file for a thermostat which is from Tuya...
Other names I found are:
Lupum Dy-107
Wholesale Dy-107
Avatto Dy-107
More information about product:
https://www.electricvalvefactory.com/product/thermostat/dy107-floor-heating-thermostat.html
DPs according this HowTo:
https://www.zigbee2mqtt.io/advanced/support-new-devices/03_find_tuya_data_points.html#_8-find-your-data-point
Datapoints:
Base data used for the implementation:
Screenshot of UI: