Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adds MOES ZC-TD 5W GU10 ZigBee RGB bulb to zigbee_smart_bulb.yaml #1762

Closed
wants to merge 1 commit into from

Conversation

zalatnaicsongor
Copy link
Contributor

Bought a zigbee rgb bulb on aliexpress (https://www.aliexpress.com/item/1005005719073628.html)
The integration discovered it as a fan or smart switch and didn't offer the smart zigbee bulb device type, this commits fixes that problem.

{
  "category": "dj",
  "product_name": "ZC-TD 5W GU10 ZigBee",
  "product_id": "rcggc0ys",
  "biz_type": 18,
  "model": "ZB-TD5-RCW-GU10",
  "sub": true,
  "icon": "https://images.tuyaeu.com/smart/icon/ay15327721968035jwx9/d4df9b682da8dc3ee1b9e518981dccd0.png"
}

@make-all
Copy link
Owner

This change will not affect detection, as the product id is not yet used for that. If you were able to get your bulb detected after this, then it was likely a coincidental change in the bulb's state that caused it to appear differently.

@zalatnaicsongor
Copy link
Contributor Author

This change will not affect detection, as the product id is not yet used for that. If you were able to get your bulb detected after this, then it was likely a coincidental change in the bulb's state that caused it to appear differently.

I've checked the debug logs. Two times the integration could not find dp 6, then magically on the third try dp 6 was there 🤷

Are there any plans to include id match in the detection heuristic or has that been ruled out?

@make-all
Copy link
Owner

It will be done, but requires local network discovery (which will only work if localtuya is not installed) so the current dps matching will need to remain as a backup.

make-all added a commit that referenced this pull request Mar 21, 2024
Make dp 6 optional to improve detection
PR #1762
@make-all make-all closed this Mar 21, 2024
@zalatnaicsongor zalatnaicsongor deleted the patch-1 branch March 21, 2024 11:32
timlaing pushed a commit to timlaing/tuya-local that referenced this pull request Aug 8, 2024
Make dp 6 optional to improve detection
PR make-all#1762
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

2 participants