Add NovaDigital SL-06 smart lock #1830
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ThomasADavis
pushed a commit
to ThomasADavis/tuya-local
that referenced
this pull request
Apr 15, 2024
History: this config was originally made with `invert: true` at dps level, where the desired effect was not produced. After yaml lint tests were added, this issue was detected and "fixed" by moving it into a `mapping`. However, the original presence of that `invert: true` seems to have been a mistake, the values should not be inverted. Discussion make-all#1830
New configs should not define entities that are already deprecated.
timlaing
pushed a commit
to timlaing/tuya-local
that referenced
this pull request
Aug 8, 2024
History: this config was originally made with `invert: true` at dps level, where the desired effect was not produced. After yaml lint tests were added, this issue was detected and "fixed" by moving it into a `mapping`. However, the original presence of that `invert: true` seems to have been a mistake, the values should not be inverted. Discussion make-all#1830
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi, everyone!
New Device: NovaDigital SL-06 smart lock
https://www.novadigitalsmart.com.br/produtos/fechadura-inteligente-com-biometria-sl-06