-
Notifications
You must be signed in to change notification settings - Fork 526
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
add support for Depauley Ceiling Fan Light #1957
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
scotttimmins
force-pushed
the
chore/add-devices
branch
2 times, most recently
from
May 27, 2024 13:40
cfc7d9b
to
bff1668
Compare
make-all
reviewed
Jun 12, 2024
custom_components/tuya_local/devices/depuley_smart_ceiling_fan.yaml
Outdated
Show resolved
Hide resolved
custom_components/tuya_local/devices/depuley_smart_ceiling_fan.yaml
Outdated
Show resolved
Hide resolved
custom_components/tuya_local/devices/depuley_smart_ceiling_fan.yaml
Outdated
Show resolved
Hide resolved
custom_components/tuya_local/devices/depuley_smart_ceiling_fan.yaml
Outdated
Show resolved
Hide resolved
custom_components/tuya_local/devices/depuley_smart_ceiling_fan.yaml
Outdated
Show resolved
Hide resolved
custom_components/tuya_local/devices/depuley_smart_ceiling_fan.yaml
Outdated
Show resolved
Hide resolved
scotttimmins
force-pushed
the
chore/add-devices
branch
from
June 12, 2024 20:40
bff1668
to
95ccb4e
Compare
scotttimmins
force-pushed
the
chore/add-devices
branch
from
June 12, 2024 20:41
95ccb4e
to
a8995dc
Compare
Thanks for your guidance - I've addressed all the issues you raised and decided to leave the |
- follow HA naming convention - add translation_keys where appropriate
timlaing
pushed a commit
to timlaing/tuya-local
that referenced
this pull request
Aug 8, 2024
- Allow use of newer tuya-device-sharing-sdk 0.2.0 appears to have been released (from dev branch), though HA 2024.6.1 is still shipping 0.1.9. But we do not want this integration to break when they update it. Discussion make-all#1998 - update docs for recent PRs make-all#1957, make-all#1958, make-all#1968, make-all#2009, make-all#2011
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I've added support for this ceiling fan with 1 issue - it does not seem to support the hs colour setting, it instead uses dps 51 (labelled mix_rgbcw).
I've had a look into this but rapidly got out of my depth.
In case you wanted to have a look yourself the data model is below as are some colour change commands from the device logs.
Feel free to disable the RGBW bits if preferred.
Device logs:
Publish Mix Rgbcw MAYA5gPoZTgA5gAA app client appName:Smart Life Publish Mix Rgbcw MAYAfAJUZTgA5gAA app client appName:Smart Life Publish Mix Rgbcw MAYyZTAzZTgA5gAA app client appName:Smart Life