Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix for caldo up t wifi #2033

Closed
wants to merge 3 commits into from
Closed

fix for caldo up t wifi #2033

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
24cfee0
fixes for caldo_up_t_wifi.yaml
sebastianciupinski Jun 21, 2024
680470a
Update caldo_up_t_wifi.yaml
sebastianciupinski Jun 21, 2024
1890470
Merge branch 'main' into main
make-all Jul 21, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 5 additions & 7 deletions custom_components/tuya_local/devices/caldo_up_t_wifi.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,20 +4,18 @@ products:
name: Olimpia Splendid Caldo Up T
primary_entity:
entity: climate
translation_only_key: heater
dps:
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There is no good reason to remove the translation_key.

- id: 1
type: boolean
name: hvac_mode
mapping:
- dps_val: true
value: heat
value: "heat_cool"
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is a heater, there is no reason to change this from heat to heat_cool, as it is not capable of automatically switching between heating and cooling.

- dps_val: false
value: "off"
- id: 2
type: integer
name: temperature
unit: C
range:
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Removing the unit is not just without reason, it breaks the integration on HA 2024.6 and later, which requires the unit to be set.

min: 18
max: 45
Expand All @@ -28,11 +26,11 @@ primary_entity:
type: string
name: preset_mode
mapping:
- dps_val: "0"
value: none
- dps_val: "1"
- dps_val: "level_1"
value: "fan only"
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

fan_only is not a standard preset name. I think this is better left as "none", which conveys that compared to "comfort" and "boost", it provides no heating.

- dps_val: "level_2"
value: comfort
- dps_val: "2"
- dps_val: "level_3"
value: boost
- id: 8
type: boolean
Expand Down