-
Notifications
You must be signed in to change notification settings - Fork 490
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add support for Casdon TD Pro 2 device #2098
Conversation
… cooking modes fault_message Status
- remove extra blank line at end of file - remove redundant light icon
YAML lint does not like the long lines. Shorter messages are just as understandable.
@make-all I have finished the modifications and have localized some of the descriptions into English. I want to do localization adaptation in Chinese, and I can do this task. I currently don’t understand how to use the translation_key to configure the fault_message value.
- id: 13
type: bitfield
name: fault_message
mapping:
- value: OK
- dps_val: 0
value: OK
- dps_val: 1
value: "er1: Chamber Overheat Protection (Sensor temperature exceeds 290°C)"
- dps_val: 2
value: "er2: Evaporation Tray Overheat Protection (Sensor temperature exceeds 200°C)"
- dps_val: 4
value: "er3: Chamber Low Temperature Protection (Temperature remains below 35°C for 5 minutes)"
- dps_val: 8
value: "er4: Evaporation Tray Low Temperature Protection (Temperature remains below 35°C for 5 minutes)"
- dps_val: 16
value: "er5: Sensor Connection Error (Open circuit in chamber or evaporation tray sensor)"
- dps_val: 32
value: "er6: Sensor Malfunction (Short circuit in chamber or evaporation tray sensor)"
- dps_val: 64
value: "er7: Display Board Communication Error"
- dps_val: 128
value: "er8: Water Tank Switch (CN7) Not Closed or Evaporation Tray NTC (CN3) Exceeds 125°C for 25 Seconds, Triggering Water Shortage Alert and Stopping Operation"
|
Two messages were still too long for yamllint, so reduced further.
@make-all Thank you for your assistance with my pull request. |
If you want to translate those messages, I suggest using a more specific translation_key, such as oven_fault at the sensor level. I am not sure that translation handles non-standard extra attributes like "fault_message", so you may need to go back to an enum class sensor just for the message. |
@make-all No problem, I will make this modification after completing the merge and localization. |
I think the translations can be a new PR, I will merge this one now. |
Add oven type device: Casdon Oven TD Pro 2.
Cloesd #2097
Preview: