Implement Arlec PC191HA Series 2 Socket #2101
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
There doesn't seem to be any reason to add a new config for this device rather than use the existing smartplugv2_energy.yaml config and ignore the missing config options. If we added a config for every single model of smartplug on the market globally, there would be thousands of configs. |
make-all
added a commit
that referenced
this pull request
Jul 11, 2024
The id seemed to be a device id, not product id. Use product id from PR #2101 instead.
Understood - makes sense. I was coming at this the other way of users might be confused with all these extraneous configuration options that don't actually work. |
timlaing
pushed a commit
to timlaing/tuya-local
that referenced
this pull request
Aug 8, 2024
The id seemed to be a device id, not product id. Use product id from PR make-all#2101 instead.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Despite stating the model number suggesting that it is a merely a revision of the original Arlec PC181HA, this is actually a redesign with the CB2S module replacing the WB2S module in the previous series.
The CB2S is newer but less technically capable and as such has quite a few features stripped out.
This PR implements the Series 2 which prevents various non-existent entities from appearing.