Added support for YX-025WB aroma diffuser #2204
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- use brand name from Aliexpress in product name - use new timer translations - add raw fault code and boolean mapping to problem sensor PR make-all#2204
make-all
added a commit
that referenced
this pull request
Aug 25, 2024
make-all
added a commit
that referenced
this pull request
Aug 25, 2024
To avoid issues on case insensitive filesystems and differences between HA slugified device name and filename, only lower case, numbers and underscores are used in filenames by convention. Also most widely used convention is brand_model_devicetype, since this is unbranded, combine model and device type into single words. PR #2204 / Issue #2182
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
These configurations seem to work with my aroma diffuser. The diffuser was a bit different from the pre-existing ones as it does not use dps id 1. I also didn't find any detailed information about the preset mode so I just left the values as itself for now. For more underlying information about the logs and product can be found in my Issue #2182