Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

avatto_trv06_radiatorvalve.yaml addon … Issue #2457 #2465

Open
wants to merge 4 commits into
base: main
Choose a base branch
from
Open
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Original file line number Diff line number Diff line change
Expand Up @@ -23,6 +23,7 @@ primary_entity:
- id: 3
type: string
name: hvac_action
optional: true
mapping:
- dps_val: opened
value: heating
Expand Down Expand Up @@ -52,3 +53,53 @@ secondary_entities:
type: boolean
optional: true
name: lock
- entity: binary_sensor
class: battery
category: diagnostic
dps:
- id: 35
type: bitfield
name: sensor
class: measurement
mapping:
- dps_val: 0
value: false
- value: true
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

In other devices that use a bitfield to indicate low battery, the low battery indication is a specific bit, and there will often be other bits indicating other things like charging. To avoid falsely indicating a low battery, it would be better to identify which bit is indicating low battery, and map that bit to true, with the default mapping being false.

- entity: switch
translation_key: anti_frost
category: config
dps:
- id: 36
type: boolean
name: switch
optional: true
mapping:
- dps_val: null
value: false
hidden: true
- entity: switch
name: Antiscale
category: config
icon: "mdi:shimmer"
dps:
- id: 39
type: boolean
name: switch
optional: true
mapping:
- dps_val: null
value: false
hidden: true
- entity: number
name: Temperature calibration
category: config
icon: "mdi:thermometer-check"
dps:
- id: 47
type: integer
optional: true
name: value
unit: C
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Unit needs to be ° since we need to avoid unit conversion in the case the user has their display preference in HA set to F, so that 0 is always 0.

range:
min: -9
max: 9