Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Re-implement natural breaks without sklearn dependency #57

Closed
brendancol opened this issue Jun 30, 2020 · 0 comments
Closed

Re-implement natural breaks without sklearn dependency #57

brendancol opened this issue Jun 30, 2020 · 0 comments
Assignees
@thuydotm
Labels
enhancement New feature or request

Comments

@brendancol
Copy link
Contributor

brendancol commented Jun 30, 2020 •
edited
Loading

Looks like @perrygeo has an awesome library for this...we just want it implemented in numba...@thuydotm let's make sure to give attribution
https://github.com/perrygeo/jenks/blob/master/jenks.pyx
@brendancol brendancol added the enhancement New feature or request label Jun 30, 2020
brendancol pushed a commit that referenced this issue Jul 23, 2020
@thuydotm
Re-implement natural breaks without sklearn dependency #57 (#89)
b247e15 
* natural break: minor fix

* wip natural_breaks() without sklearn dependency

* jenks: add reference

* natural breaks: clean code

* natural break: bug fixes

* natural breaks: numba-ize

* update dependencies

* natural breaks: update docs, test and example

* xrspatial tests: correct agg coords assertion
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@thuydotm thuydotm

Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@brendancol @thuydotm