feat: support existingSecret for plane-enterprise chart #54
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 2 commits
October 13, 2024 14:29
This change introduces support for supplying an existingSecret for doc-store and app-secrets; previously, users had to specify secret values such as aws access keys, database urls with passwords, and the application secret_key. This makes it impossible to safely manage the helm installation via GitOps. Users may continue to provide values this way for simplicity, but may also choose to create these secrets themselves and specify them by reference.
|
I have marked this as Draft for now, but would love to hear back from maintainers regarding preferred direction for this change. I'm happy to contribute more extensively, or allow the maintainer team to take over, just let me know. We are actively blocked from deploying this in our production environment (which is managed by GitOps) until this issue is resolved. We may start pushing it forward from my fork in which case I may push additional changes and mark ready for review after more testing. |
|
Bad ordering, but I have now opened issue #55 to track |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change introduces support for supplying an existingSecret for doc-store and app-secrets; previously, users had to specify secret values such as aws access keys, database urls with passwords, and the application secret_key. This makes it impossible to safely manage the helm installation via GitOps. Users may continue to provide values this way for simplicity, but may also choose to create these secrets themselves and specify them by reference.