Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: newly added cycle doesnt appear unlelss the page is manually reloaded #2673

Conversation

AbhiShake1
Copy link
Contributor

@AbhiShake1 AbhiShake1 commented Nov 6, 2023

this PR fixes issue #2666 by using cycles instead of project details from store, which refreshes when cycles is updated. as a side effect, it also fixes the weird layout (different from the original layout) when all cycles are deleted.

Copy link

vercel bot commented Nov 6, 2023

@AbhiShake1 is attempting to deploy a commit to the Plane Team on Vercel.

A member of the Team first needs to authorize it.

@AbhiShake1 AbhiShake1 changed the base branch from master to develop November 6, 2023 13:57
@AbhiShake1 AbhiShake1 changed the title 11 06 fix newly added cycle doesnt appear unlelss the page is manually reloaded fix: newly added cycle doesnt appear unlelss the page is manually reloaded Nov 6, 2023
@sriramveeraghanta sriramveeraghanta merged commit e945aa9 into makeplane:develop Nov 20, 2023
1 check passed
sriramveeraghanta pushed a commit that referenced this pull request Dec 7, 2023
…oaded (#2673)

* fix: newly added cycle doesnt appear unlelss the page is manually reloaded

* Delete \

* Delete web/layouts/profile-layout/profile-sidebar.tsx

* Update cycles.store.ts

* fix: remove duplicate type declaration

---------

Co-authored-by: Aaryan Khandelwal <65252264+aaryan610@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🐛bug Something isn't working 🌐frontend
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[bug]: newly added cycle doesnt appear unlelss the page is manually reloaded
3 participants