Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: complete pages editor not clickable, recent pages calculation logic #2820

Merged
merged 5 commits into from
Nov 21, 2023

Conversation

aaryan610
Copy link
Collaborator

This PR fixes some bugs related to Pages

Bug fixes-

  1. Pages editor clickable only on the space occupied by the text.
  2. Create/update page modal getting reset even before the page gets created/updated.

Improvements-

  1. Recent pages computed function logic to calculate pages for Today, Yesterday, This week and Older.
image
  1. Pages store computed functions to return undefined if pages are not present for a particular project.

@aaryan610 aaryan610 added 🐛bug Something isn't working 🌐frontend labels Nov 21, 2023
@aaryan610 aaryan610 added this to the 0.14-dev milestone Nov 21, 2023
Copy link

vercel bot commented Nov 21, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

6 Ignored Deployments
Name Status Preview Comments Updated (UTC)
plane ⬜️ Ignored (Inspect) Visit Preview Nov 21, 2023 9:36am
plane-dev ⬜️ Ignored (Inspect) Visit Preview Nov 21, 2023 9:36am
plane-sh ⬜️ Ignored (Inspect) Visit Preview Nov 21, 2023 9:36am
plane-sh-dev ⬜️ Ignored (Inspect) Visit Preview Nov 21, 2023 9:36am
plane-sh-stage ⬜️ Ignored (Inspect) Visit Preview Nov 21, 2023 9:36am
plane-staging ⬜️ Ignored (Inspect) Visit Preview Nov 21, 2023 9:36am

@aaryan610 aaryan610 changed the title fix: pages editor not clickable, recent pages calculation logic fix: complete pages editor not clickable, recent pages calculation logic Nov 21, 2023
@sriramveeraghanta sriramveeraghanta merged commit 982eba0 into develop Nov 21, 2023
10 of 12 checks passed
@sriramveeraghanta sriramveeraghanta deleted the fix/pages_bugs branch November 21, 2023 10:17
sriramveeraghanta pushed a commit that referenced this pull request Dec 7, 2023
…gic (#2820)

* fix: whole editor not clickable

* fix: recent pages calculation

* chore: update older pages calculation logic in recent pages list

* fix: archived pages computed function

* chore: add type for older pages
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🐛bug Something isn't working 🌐frontend
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants