Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: modal and dropdown improvement #3332

Merged
merged 9 commits into from
Jan 10, 2024

Conversation

anmolsinghbhatia
Copy link
Collaborator

This PR includes the following enhancements to modals and dropdowns:

  • Added tab indexing to modals for improved navigation.
  • Implemented functionality to close modals by pressing the 'Esc' key.
  • Improved keyboard accessibility for dropdowns, allowing users to open them by navigating and pressing 'Enter', and close them with 'Esc' and implement outside click detection.
  • Ensured consistent alignment for modals.

@gurusainath gurusainath changed the base branch from develop to chore/mobx_issue_detail January 9, 2024 12:45
@gurusainath gurusainath changed the base branch from chore/mobx_issue_detail to develop January 9, 2024 12:46
@sriramveeraghanta sriramveeraghanta merged commit 8b884ab into develop Jan 10, 2024
6 of 8 checks passed
@sriramveeraghanta sriramveeraghanta deleted the chore/modal_and_dropdown_improvement branch January 10, 2024 06:51
sriramveeraghanta pushed a commit that referenced this pull request Jan 22, 2024
* dev: dropdown key down custom hook added

* chore: plane ui dropdowns updated

* chore: cycle and module tab index added in modals

* chore: view and page tab index added in modals

* chore: issue modal tab indexing added

* chore: project modal tab indexing added

* fix: build fix

* build-error: build error in pages new structure and reverted back to old page structure

---------

Co-authored-by: gurusainath <gurusainath007@gmail.com>
sriramveeraghanta pushed a commit that referenced this pull request Jan 22, 2024
* dev: dropdown key down custom hook added

* chore: plane ui dropdowns updated

* chore: cycle and module tab index added in modals

* chore: view and page tab index added in modals

* chore: issue modal tab indexing added

* chore: project modal tab indexing added

* fix: build fix

* build-error: build error in pages new structure and reverted back to old page structure

---------

Co-authored-by: gurusainath <gurusainath007@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants