Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: Removed explicit dependencies and cleaned up turbo config #3388

Merged
merged 2 commits into from
Jan 17, 2024

Conversation

Palanikannan1437
Copy link
Collaborator

@Palanikannan1437 Palanikannan1437 commented Jan 17, 2024

Why?

We have a number of explicit dependencies in our turbo.json, which isn't necessary to do as it'll get very difficulty to maintain as no of dependencies go up since turborepo automatically manages it using it's task dependency graph.

What?

This PR uses the topological relationship provided by the ^ operator in turbo.json

"build": {
      "dependsOn": [
        "^build"
      ],
},

The ^build syntax means that when we run turbo run build, then this build command of a particular package (be it web/space/editor/ui) will first run the build commands of their respective dependencies.

Other changes

I've done the same with develop command (that helps us run yarn dev to automatically run turbo run develop in web and space projects for better DX) and the dev command (for other packages) to automatically first run their dependencies' build commands.

"develop": {
      "cache": false,
      "persistent": true,
      "dependsOn": [
        "^build"
      ]
}


 "dev": {
      "cache": false,
      "persistent": true,
      "dependsOn": [
        "^build"
      ]
},

Also this pr includes the turbo upgrade changes

@sriramveeraghanta sriramveeraghanta merged commit a1d27a1 into develop Jan 17, 2024
7 of 8 checks passed
@sriramveeraghanta sriramveeraghanta deleted the chore/turbo-simplified branch January 17, 2024 11:54
sriramveeraghanta added a commit that referenced this pull request Jan 22, 2024
…3388)

* Removed explicit dependencies and cleaned up turbo config

* fix: upgrade turbo

---------

Co-authored-by: sriram veeraghanta <veeraghanta.sriram@gmail.com>
sriramveeraghanta added a commit that referenced this pull request Jan 22, 2024
…3388)

* Removed explicit dependencies and cleaned up turbo config

* fix: upgrade turbo

---------

Co-authored-by: sriram veeraghanta <veeraghanta.sriram@gmail.com>
@Palanikannan1437 Palanikannan1437 added this to the v0.15-dev milestone Jan 26, 2024
@Palanikannan1437 Palanikannan1437 changed the title [chore]: Removed explicit dependencies and cleaned up turbo config chore: Removed explicit dependencies and cleaned up turbo config Jan 31, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants