Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor: Gantt chart layout #3585

Merged
merged 19 commits into from
Feb 12, 2024
Merged

refactor: Gantt chart layout #3585

merged 19 commits into from
Feb 12, 2024

Conversation

aaryan610
Copy link
Collaborator

@aaryan610 aaryan610 commented Feb 7, 2024 •
edited
Loading

This PR focuses on Gantt chart refactoring and bug fixes

Refactor:

  1. Created smaller components for various components for better code readability and maintenance.
  2. Updated the folder structure.
  3. Removed junk code.
  4. Converted all the blocks to MobX observables for real-time changes.
  5. Created a constant file to store constant heights for blocks and header.

Bug fixes:

  1. There's no scroll sync between the sidebar and the timeline of the Gantt chart.
Before After
Screen.Recording.2024-02-07.at.4.42.27.PM.mov
Screen.Recording.2024-02-07.at.5.13.07.PM.mov
  1. The quick-add issue button doesn't stick to the bottom of the sidebar.
Before After
Screen.Recording.2024-02-07.at.4.49.27.PM.mov
Screen.Recording.2024-02-07.at.5.13.07.PM.mov

@aaryan610 aaryan610 added this to the v0.16 milestone Feb 7, 2024
@aaryan610 aaryan610 marked this pull request as draft February 7, 2024 10:49
@CLAassistant
Copy link

CLAassistant commented Feb 8, 2024 •
edited
Loading

CLA assistant check
All committers have signed the CLA.

@aaryan610 aaryan610 marked this pull request as ready for review February 12, 2024 06:46
rahulramesha
rahulramesha reviewed Feb 12, 2024
View reviewed changes
Copy link
Collaborator

@rahulramesha rahulramesha left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Most of it looks good, just a small change request

web/components/gantt-chart/chart/root.tsx Outdated Show resolved Hide resolved
@sriramveeraghanta sriramveeraghanta merged commit 963d26c into develop Feb 12, 2024
7 of 9 checks passed
@sriramveeraghanta sriramveeraghanta deleted the fix/gantt-scroll branch February 12, 2024 09:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rahulramesha rahulramesha rahulramesha left review comments

@sriramveeraghanta sriramveeraghanta sriramveeraghanta approved these changes

Assignees
No one assigned
Labels
🐛bug Something isn't working 🌐frontend 🌟improvement 🛠️refactor
Projects
None yet
Milestone
v0.16-dev
Development

Successfully merging this pull request may close these issues.
4 participants
@aaryan610 @CLAassistant @sriramveeraghanta @rahulramesha