Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[WEB-591] fix: navigating to a page through Cmd K throws error #3827

Merged
merged 1 commit into from
Feb 28, 2024
Merged

[WEB-591] fix: navigating to a page through Cmd K throws error #3827

merged 1 commit into from
Feb 28, 2024

Conversation

aaryan610
Copy link
Collaborator

Problem:

  1. When navigating to a page from the Cmd K modal in the dashboard, the application crashes.

Solution:

  1. When the projectId is not present in the route, the usePage hook throws an error, but now it simply returns undefined which is handled in the component level.

Plane issue: WEB-591

@aaryan610 aaryan610 added 🐛bug Something isn't working 🌐frontend labels Feb 28, 2024
@aaryan610 aaryan610 added this to the v0.17.0-dev milestone Feb 28, 2024
@sriramveeraghanta sriramveeraghanta merged commit c4028ef into develop Feb 28, 2024
7 of 9 checks passed
@sriramveeraghanta sriramveeraghanta deleted the fix/use-page-hook branch February 28, 2024 13:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sriramveeraghanta sriramveeraghanta sriramveeraghanta approved these changes

@gurusainath gurusainath Awaiting requested review from gurusainath

Assignees
No one assigned
Labels
🐛bug Something isn't working 🌐frontend
Projects
None yet
Milestone
v0.17.0-dev
Development

Successfully merging this pull request may close these issues.
2 participants
@aaryan610 @sriramveeraghanta