-
Notifications
You must be signed in to change notification settings - Fork 1.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[WEB-434] feat: add support to insert a new empty line on clicking at bottom of the editor #3856
Merged
sriramveeraghanta
merged 13 commits into
develop
from
feat/new-node-insert-at-bottom-click
Mar 11, 2024
Merged
[WEB-434] feat: add support to insert a new empty line on clicking at bottom of the editor #3856
sriramveeraghanta
merged 13 commits into
develop
from
feat/new-node-insert-at-bottom-click
Mar 11, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
TODO: blockquote at last node
Palanikannan1437
force-pushed
the
feat/new-node-insert-at-bottom-click
branch
from
March 8, 2024 12:28
af9a842
to
3f412b5
Compare
Palanikannan1437
changed the title
fix: Added support to insert a new line at the bottom of the editor on clicking at bottom of the editor
[WEB-434] fix: Added support to insert a new line at the bottom of the editor on clicking at bottom of the editor
Mar 11, 2024
sriramveeraghanta
approved these changes
Mar 11, 2024
Palanikannan1437
changed the title
[WEB-434] fix: Added support to insert a new line at the bottom of the editor on clicking at bottom of the editor
[WEB-434] feat: Added support to insert a new line at the bottom of the editor on clicking at bottom of the editor
Mar 11, 2024
Palanikannan1437
changed the title
[WEB-434] feat: Added support to insert a new line at the bottom of the editor on clicking at bottom of the editor
[WEB-434] feat: add support to insert a new empty line on clicking at bottom of the editor
Mar 11, 2024
…de-insert-at-bottom-click
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR adds in support to add empty spaces wherever you weren't able to navigate into areas in a more intuitive way for all the below cases.
Tables
Images
In cases where you want to insert between nodes, you can either use the gap cursor that'll appear (example if image and table are consecutively placed) using your keyboard, or use the drag handles.
Added support to insert a new line at the bottom of the editor on clicking on the editor container.
Added support to automatically insert a new empty node at bottom of the table and image while navigating via down arrow in the table from any of the cells in the last row.