Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[WEB-434] feat: add support to insert a new empty line on clicking at bottom of the editor #3856

Merged
merged 13 commits into from
Mar 11, 2024

Conversation

Palanikannan1437
Copy link
Collaborator

@Palanikannan1437 Palanikannan1437 commented Mar 1, 2024

Description

This PR adds in support to add empty spaces wherever you weren't able to navigate into areas in a more intuitive way for all the below cases.

Tables

  1. If table is at the end of the document -> You can navigate to ANY cell in the last row of the table and press down arrow key which will insert a new empty node at the bottom of the table and focus the cursor onto it.
  2. If table is at the start of the document -> You can navigate to any cell in the first row of the table and press up arrow key which will insert a new empty node at the top of the table and focus the cursor onto it.

Images

  1. If image is at the end of the document -> You can navigate to the image and press down arrow key which will insert a new empty node at the bottom of the image and focus the cursor onto it.
  2. If image is at the start of the document -> You can navigate to the image and press up arrow key which will insert a new empty node at the top of the image and focus the cursor onto it.

In cases where you want to insert between nodes, you can either use the gap cursor that'll appear (example if image and table are consecutively placed) using your keyboard, or use the drag handles.

Added support to insert a new line at the bottom of the editor on clicking on the editor container.

Added support to automatically insert a new empty node at bottom of the table and image while navigating via down arrow in the table from any of the cells in the last row.

@Palanikannan1437 Palanikannan1437 self-assigned this Mar 1, 2024
@Palanikannan1437 Palanikannan1437 force-pushed the feat/new-node-insert-at-bottom-click branch from af9a842 to 3f412b5 Compare March 8, 2024 12:28
@Palanikannan1437 Palanikannan1437 marked this pull request as ready for review March 8, 2024 12:38
@Palanikannan1437 Palanikannan1437 changed the title fix: Added support to insert a new line at the bottom of the editor on clicking at bottom of the editor [WEB-434] fix: Added support to insert a new line at the bottom of the editor on clicking at bottom of the editor Mar 11, 2024
@Palanikannan1437 Palanikannan1437 changed the title [WEB-434] fix: Added support to insert a new line at the bottom of the editor on clicking at bottom of the editor [WEB-434] feat: Added support to insert a new line at the bottom of the editor on clicking at bottom of the editor Mar 11, 2024
@Palanikannan1437 Palanikannan1437 changed the title [WEB-434] feat: Added support to insert a new line at the bottom of the editor on clicking at bottom of the editor [WEB-434] feat: add support to insert a new empty line on clicking at bottom of the editor Mar 11, 2024
@sriramveeraghanta sriramveeraghanta merged commit 899771a into develop Mar 11, 2024
12 of 14 checks passed
@sriramveeraghanta sriramveeraghanta deleted the feat/new-node-insert-at-bottom-click branch March 11, 2024 15:25
@Palanikannan1437 Palanikannan1437 added this to the v0.17.0-dev milestone Mar 11, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants