Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[WEB-566] feat: Added text to empty color picker boxes and other fixes #3867

Merged
merged 2 commits into from
Mar 6, 2024
Merged

[WEB-566] feat: Added text to empty color picker boxes and other fixes #3867

merged 2 commits into from
Mar 6, 2024

Conversation

Palanikannan1437
Copy link
Collaborator

Description

  1. Added text to empty color picker boxes for both light and dark modes
Light mode Dark mode
image image
  1. This PR fixes the issue in which row/col action pickers in tables are shown over the modals if there's an editor behind it.
Before After
image image
  1. Added more visible hover state for table operations using row and column picker actions

@Palanikannan1437 Palanikannan1437 self-assigned this Mar 4, 2024
@Palanikannan1437 Palanikannan1437 added this to the v0.17.0-dev milestone Mar 4, 2024
@pushya22 pushya22 requested a review from gurusainath March 4, 2024 13:38
@sriramveeraghanta sriramveeraghanta merged commit e1db39f into develop Mar 6, 2024
8 of 9 checks passed
@sriramveeraghanta sriramveeraghanta deleted the fix/table-css-colorpicker-indicators branch March 6, 2024 08:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gurusainath gurusainath gurusainath approved these changes

@sriramveeraghanta sriramveeraghanta Awaiting requested review from sriramveeraghanta

Assignees

@Palanikannan1437 Palanikannan1437

Labels
✍️editor
Projects
None yet
Milestone
v0.17.0-dev
Development

Successfully merging this pull request may close these issues.
3 participants
@Palanikannan1437 @gurusainath @sriramveeraghanta