Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[WEB-663] fix: project members settings flickering #3894

Merged
merged 1 commit into from
Mar 7, 2024

Conversation

1akhanBaheti
Copy link
Collaborator

@1akhanBaheti 1akhanBaheti commented Mar 7, 2024

Problem:

  1. When either the project lead or default assignee is changed, the other property automatically changes to None for a blink.
  2. Default assignee & project lead container have slight differences in height when one of the property have value as None.

Solution:

  1. While updating project details, one of the property value was going as undefined, so fixed it by checking for its value in currentProjectDetails.
  2. Gave fixed height to both property container's.

Before:

project-members-settings-problem.mp4

After:

project-member-settings-solution.mp4

This PR is attached to WEB-663

@1akhanBaheti 1akhanBaheti added this to the v0.17.0-dev milestone Mar 7, 2024
@1akhanBaheti 1akhanBaheti self-assigned this Mar 7, 2024
@1akhanBaheti 1akhanBaheti changed the title fix: project members settings flickering [WEB-663] fix: project members settings flickering Mar 7, 2024
@pushya22 pushya22 requested a review from rahulramesha March 7, 2024 07:04
@1akhanBaheti 1akhanBaheti requested a review from gurusainath March 7, 2024 07:04
@1akhanBaheti 1akhanBaheti marked this pull request as ready for review March 7, 2024 07:04
@sriramveeraghanta sriramveeraghanta merged commit b03f6a8 into develop Mar 7, 2024
12 of 14 checks passed
@sriramveeraghanta sriramveeraghanta deleted the fix/project-member-default-settings branch March 7, 2024 07:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants