-
Notifications
You must be signed in to change notification settings - Fork 1.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[WEB-460] refactor: editors, chore: pages list improvement #4090
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pablohashescobar
approved these changes
Apr 11, 2024
…ne/plane into refactor-document-editor
rahulramesha
requested changes
Apr 11, 2024
rahulramesha
approved these changes
Apr 11, 2024
aaryan610
changed the title
[WEB-460] refactor: document editor, chore: pages list improvement
[WEB-460] refactor: editors, chore: pages list improvement
Apr 11, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Document editor refactoring
This PR is targets keeping the document editor lean and exposing APIs to control the editor from outside using Refs and useImperativeHandle instead of having the application logic inside the editor itself taking control from React.
Ref methods exposed currently
The methods exposed to the parent forwarded ref (the web app holds onto this) by the
useImperativeHandle
exposed methods that holds on to the local child state (the initialised editor instance) to perform actions related to the editor.And @aaryan610 has completely separated the UI in a modular way that was previously messy and tied to the document editor into the
web
app and control any editor related tasks using the above methods.A careful consideration
So we're taking control from React, that comes at a cost...things aren't so reactive anymore (pun intended).
UI changes
Typography
Updated the line height, margins, font weight, font size of the headings and paragraphs making the document much more readable and consistent.
Table
To-do list
Code block
Inline code
inline.code.blocks.mp4
New dark mode colors
New features
Full width toggle
Users can now turn the full width option on to make the page body occupy full width, hiding the outline section.
Screen.Recording.2024-04-05.at.7.14.47.PM.mov
Auto merging of lists
list.deletion.and.auto.merging.mp4
Drag and Drop
drag.and.drop.lists.mp4
Bug fixes
Pages list improvements
New tabs and list options
The list page now features only 3 tabs- Public, Private and Archived.
Page access(public/private) can now be changed from the quick actions dropdown directly, an option missing currently.
Screen.Recording.2024-04-05.at.1.35.34.PM.mov
Ordering, searching and filtering
Screen.Recording.2024-04-05.at.1.41.26.PM.mov
Plane issues: WEB-74, WEB-119, WEB-426, WEB-430, WEB-460, WEB-480, WEB-528, WEB-718