-
Notifications
You must be signed in to change notification settings - Fork 1.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[WEB-2021] fix: mutating the inbox count on the sidebar and inbox tab when we click mark all as read #5191
[WEB-2021] fix: mutating the inbox count on the sidebar and inbox tab when we click mark all as read #5191
Conversation
…ick mark all as read
WalkthroughThe changes enhance the Changes
Poem
Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media? TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (invoked as PR comments)
Additionally, you can add CodeRabbit Configuration File (
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actionable comments posted: 0
Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Files selected for processing (1)
- web/core/store/notifications/workspace-notifications.store.ts (1 hunks)
Additional comments not posted (1)
web/core/store/notifications/workspace-notifications.store.ts (1)
376-382
: LGTM! But verify the correct usage of theupdate
function andcurrentNotificationTab
.The code changes are approved. The
update
function is used to set the unread notifications count to zero based on the current notification tab.However, ensure that the
update
function is used correctly and that thecurrentNotificationTab
is set appropriately elsewhere in the code.
Problem Statement:
In the inbox, when we click the option
mark all as read
the notification count is not mutating in the workspace app sidebar badge and inbox tab badgeSolution:
When we click
mark all as read
in the inbox we are mutating the storeunread notification count
observerChanges:
Plane Issue:
[WEB-2021]
Summary by CodeRabbit