[WEB-2294] fix: remove 'Add Project' button from archives route and remove it from the dropdown in header #5469
Conversation
…om the dropdown in header
WalkthroughThe changes involve modifications to the project filtering and header components in the application. The Changes
Poem
Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media? TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
CodeRabbit Configuration File (
|
web/core/components/project/root.tsx
Outdated
| <div className="border-b border-custom-border-200 px-5 py-3"> | ||
| <ProjectAppliedFiltersList | ||
| appliedFilters={currentWorkspaceFilters ?? {}} | ||
| appliedDisplayFilters={currentWorkspaceAppliedDisplayFilters ?? []} | ||
| appliedDisplayFilters={currentWorkspaceAppliedDisplayFilters?.filter(filter => filter !== "archived_projects") ?? []} |
There was a problem hiding this comment.
Define a variable for this and use that variable only in lines 72-74 to just check the length
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
Actionable comments posted: 1
Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Files selected for processing (3)
- web/core/components/project/dropdowns/filters/root.tsx (1 hunks)
- web/core/components/project/header.tsx (1 hunks)
- web/core/components/project/root.tsx (1 hunks)
Additional comments not posted (3)
web/core/components/project/root.tsx (1)
78-78: Correct implementation of filter exclusion.The implementation correctly filters out "archived_projects" from the displayed filters, aligning with the PR objectives to streamline the user interface.
The code changes are approved.
web/core/components/project/dropdowns/filters/root.tsx (1)
Line range hint
1-50: Approval of Changes inProjectFiltersSelectionComponentThe removal of the
FilterOptionfor archived projects, as described in the summary, aligns with the PR objectives to streamline the interface. The remaining implementation of the component appears correct and well-structured.web/core/components/project/header.tsx (1)
180-180: Approval of Changes inProjectsBaseHeaderComponentThe addition of the
!isArchivedcondition to the button rendering logic is a thoughtful change that aligns with the PR objectives to streamline interactions within archived projects. The overall implementation of the component remains robust and well-structured.
web/core/components/project/root.tsx
Outdated
| (currentWorkspaceAppliedDisplayFilters?.length !== 0 && | ||
| !(currentWorkspaceAppliedDisplayFilters?.length==1 && | ||
| !(currentWorkspaceAppliedDisplayFilters?.indexOf("archived_projects")===-1)))) && ( |
There was a problem hiding this comment.
Refine conditional rendering logic for clarity.
The updated condition effectively prevents the display of the filter section when only "archived_projects" is present. However, the logic can be simplified for better readability and maintainability.
Consider refactoring the condition to use more descriptive variable names or decompose it into smaller, more readable conditions. Here's a suggested refactor:
- (currentWorkspaceAppliedDisplayFilters?.length !== 0 &&
- !(currentWorkspaceAppliedDisplayFilters?.length==1 &&
- !(currentWorkspaceAppliedDisplayFilters?.indexOf("archived_projects")===-1)))
+ const isOnlyArchived = currentWorkspaceAppliedDisplayFilters?.length === 1 && currentWorkspaceAppliedDisplayFilters.includes("archived_projects");
+ (currentWorkspaceAppliedDisplayFilters?.length !== 0 && !isOnlyArchived)Committable suggestion
‼️ IMPORTANT
Carefully review the code before committing. Ensure that it accurately replaces the highlighted code, contains no missing lines, and has no issues with indentation. Thoroughly test & benchmark the code to ensure it meets the requirements.
| (currentWorkspaceAppliedDisplayFilters?.length !== 0 && | |
| !(currentWorkspaceAppliedDisplayFilters?.length==1 && | |
| !(currentWorkspaceAppliedDisplayFilters?.indexOf("archived_projects")===-1)))) && ( | |
| const isOnlyArchived = currentWorkspaceAppliedDisplayFilters?.length === 1 && currentWorkspaceAppliedDisplayFilters.includes("archived_projects"); | |
| (currentWorkspaceAppliedDisplayFilters?.length !== 0 && !isOnlyArchived) && ( |
There was a problem hiding this comment.
Actionable comments posted: 0
Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Files selected for processing (1)
- web/core/components/project/root.tsx (2 hunks)
Files skipped from review as they are similar to previous changes (1)
- web/core/components/project/root.tsx
There was a problem hiding this comment.
Actionable comments posted: 0
Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Files selected for processing (2)
- web/core/components/project/card-list.tsx (1 hunks)
- web/core/components/project/root.tsx (2 hunks)
Files skipped from review due to trivial changes (1)
- web/core/components/project/card-list.tsx
Additional comments not posted (5)
web/core/components/project/root.tsx (5)
33-34: Simplify theisArchivedcheck.The current implementation of
isArchivedis straightforward and correctly checks if the pathname includes "/archives". This is a clean and efficient way to determine the archived status.The code changes are approved.
35-38: Refine the filtering logic for display filters.The logic to exclude "archived_projects" from
allowedDisplayFiltersis implemented correctly. This ensures that archived projects are not displayed inappropriately, aligning with the PR's objectives to streamline the UI.The code changes are approved.
64-64: Ensure consistent filter updates for archived projects.The conditional update of display filters based on
isArchivedstatus withinhandleClearAllFiltersis a smart way to manage the state dynamically. This ensures that the filter state reflects the current UI context, which is crucial for maintaining a consistent user experience.The code changes are approved.
68-69: Optimize the useEffect hook for updating display filters.The use of a ternary operator to conditionally update display filters based on the
isArchivedstatus is a clean and efficient approach. This minimizes unnecessary updates and ensures that the filters are correctly set based on the current route.The code changes are approved.
77-81: Validate the condition for displaying the filter section.The condition to display the filter section only when there are allowed display filters or non-zero total filters is a good practice. It prevents the display of an empty or irrelevant filter section, enhancing the user interface by showing only pertinent information.
The code changes are approved.
Changes:
Previous State:
New State:
Reference:
[WEB-2294]
Summary by CodeRabbit
New Features
Bug Fixes
Style