-
Notifications
You must be signed in to change notification settings - Fork 1.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[WEB-2311] fix: update the message display when deactivating/deleting project #5475
Conversation
WalkthroughThe changes involve modifications to the text content in two components: Changes
Sequence Diagram(s)sequenceDiagram
participant User
participant ProfileSettingsPage
participant DeleteProjectSection
User->>ProfileSettingsPage: Request account deactivation
ProfileSettingsPage-->>User: Display deactivation message (simplified)
User->>DeleteProjectSection: Request project deletion
DeleteProjectSection-->>User: Display deletion message (simplified)
Poem
Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media? TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
CodeRabbit Configuration File (
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actionable comments posted: 2
@@ -37,8 +37,7 @@ export const DeleteProjectSection: React.FC<IDeleteProjectSection> = (props) => | |||
<Disclosure.Panel> | |||
<div className="flex flex-col gap-8 pt-4"> | |||
<span className="text-sm tracking-tight"> | |||
The danger zone of the project delete page is a critical area that requires careful consideration and | |||
attention. When deleting a project, all of the data and resources within that project will be | |||
When deleting a project, all of the data and resources within that project will be |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Consider revising the deletion warning message for clarity and caution.
The updated message is straightforward but may not sufficiently emphasize the irreversible nature of deleting a project. Consider reintroducing some cautionary language to ensure users are fully aware of the consequences before proceeding.
@@ -426,8 +426,7 @@ const ProfileSettingsPage = observer(() => { | |||
<Disclosure.Panel> | |||
<div className="flex flex-col gap-8"> | |||
<span className="text-sm tracking-tight"> | |||
The danger zone of the profile page is a critical area that requires careful consideration and | |||
attention. When deactivating an account, all of the data and resources within that account will be | |||
When deactivating an account, all of the data and resources within that account will be |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Consider revising the deactivation warning message for clarity and caution.
The updated message is straightforward but may not sufficiently emphasize the irreversible nature of deactivating an account. Consider reintroducing some cautionary language to ensure users are fully aware of the consequences before proceeding.
Changes:
Update the message display when deactivating/deleting.
Previous State:

New State:
Reference:
[WEB-2311]
Summary by CodeRabbit