Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[WEB-2311] fix: update the message display when deactivating/deleting project #5475

Merged
merged 1 commit into from
Aug 30, 2024

Conversation

sharma01ketan
Copy link
Collaborator

@sharma01ketan sharma01ketan commented Aug 30, 2024

Changes:

Update the message display when deactivating/deleting.

Previous State:
Screenshot 2024-08-30 at 7 52 29 PM

New State:

  1. Change appears when deactivation ID.
Screenshot 2024-08-30 at 7 49 12 PM
  1. Change appears when deleting project.
Screenshot 2024-08-30 at 7 50 40 PM

Reference:

[WEB-2311]

Summary by CodeRabbit

  • Content Updates
    • Modified warning messages on the Profile Settings and Project Deletion pages to simplify language, reducing emphasis on caution for account deactivation and project deletion.

Copy link
Contributor

coderabbitai bot commented Aug 30, 2024

Walkthrough

The changes involve modifications to the text content in two components: ProfileSettingsPage and DeleteProjectSection. In both cases, cautionary language regarding account deactivation and project deletion has been removed, simplifying the messaging. The revised text still communicates the permanence of the actions but reduces the emphasis on the seriousness of the consequences.

Changes

File Path Change Summary
web/app/profile/page.tsx, web/core/components/project/settings/delete-project-section.tsx Removed cautionary language emphasizing the seriousness of account deactivation and project deletion. Simplified the messaging while still conveying permanence.

Sequence Diagram(s)

sequenceDiagram
    participant User
    participant ProfileSettingsPage
    participant DeleteProjectSection

    User->>ProfileSettingsPage: Request account deactivation
    ProfileSettingsPage-->>User: Display deactivation message (simplified)
    User->>DeleteProjectSection: Request project deletion
    DeleteProjectSection-->>User: Display deletion message (simplified)
Loading

Poem

🐰 In a world where choices are made,
A rabbit hops, unafraid.
With words now light, and caution shed,
Decisions dance in the mind instead.
So leap with joy, and take your chance,
For every change, a new romance! 🌼✨


Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

Share
Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>.
    • Generate unit testing code for this file.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai generate unit testing code for this file.
    • @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai generate interesting stats about this repository and render them as a table.
    • @coderabbitai show all the console.log statements in this repository.
    • @coderabbitai read src/utils.ts and generate unit testing code.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
    • @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai full review to do a full review from scratch and review all the files again.
  • @coderabbitai summary to regenerate the summary of the PR.
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
  • @coderabbitai help to get help.

Other keywords and placeholders

  • Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
  • Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
  • Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

  • You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
  • Please see the configuration documentation for more information.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

@pushya22 pushya22 changed the title [WEB-2311] fix: changed the old message to the new one [WEB-2311] fix: update the message display when deactivating/deleting project Aug 30, 2024
@pushya22 pushya22 merged commit 9d9a812 into preview Aug 30, 2024
11 of 14 checks passed
@pushya22 pushya22 deleted the fix/remove-danger-message branch August 30, 2024 14:28
Copy link
Contributor

@coderabbitai coderabbitai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 2

Review details

Configuration used: CodeRabbit UI
Review profile: CHILL

Commits

Files that changed from the base of the PR and between b9f78ba and bcb1aca.

Files selected for processing (2)
  • web/app/profile/page.tsx (1 hunks)
  • web/core/components/project/settings/delete-project-section.tsx (1 hunks)

@@ -37,8 +37,7 @@ export const DeleteProjectSection: React.FC<IDeleteProjectSection> = (props) =>
<Disclosure.Panel>
<div className="flex flex-col gap-8 pt-4">
<span className="text-sm tracking-tight">
The danger zone of the project delete page is a critical area that requires careful consideration and
attention. When deleting a project, all of the data and resources within that project will be
When deleting a project, all of the data and resources within that project will be
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Consider revising the deletion warning message for clarity and caution.

The updated message is straightforward but may not sufficiently emphasize the irreversible nature of deleting a project. Consider reintroducing some cautionary language to ensure users are fully aware of the consequences before proceeding.

@@ -426,8 +426,7 @@ const ProfileSettingsPage = observer(() => {
<Disclosure.Panel>
<div className="flex flex-col gap-8">
<span className="text-sm tracking-tight">
The danger zone of the profile page is a critical area that requires careful consideration and
attention. When deactivating an account, all of the data and resources within that account will be
When deactivating an account, all of the data and resources within that account will be
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Consider revising the deactivation warning message for clarity and caution.

The updated message is straightforward but may not sufficiently emphasize the irreversible nature of deactivating an account. Consider reintroducing some cautionary language to ensure users are fully aware of the consequences before proceeding.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants