-
Notifications
You must be signed in to change notification settings - Fork 1.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[WEB-2674] chore: open parent issues in peek-overview from the parent badge. #5872
Conversation
WalkthroughThe pull request introduces modifications to the Changes
Possibly related PRs
Suggested labels
Suggested reviewers
Poem
📜 Recent review detailsConfiguration used: CodeRabbit UI 📒 Files selected for processing (1)
🚧 Files skipped from review as they are similar to previous changes (1)
Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media? 🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
CodeRabbit Configuration File (
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actionable comments posted: 0
🧹 Outside diff range and nitpick comments (1)
web/core/components/issues/issue-detail/parent/root.tsx (1)
48-52
: LGTM: ControlLink implementation looks good.The replacement of
Link
withControlLink
and the addition of theonClick
handler successfully implement the desired functionality for opening parent issues in peek-overview. This change aligns perfectly with the PR objectives.Consider extracting the
onClick
handler to a separate function within the component for better readability:const handleParentIssueClick = () => handleRedirection(workspaceSlug, parentIssue, isMobile); // Then in JSX: <ControlLink href={`/${workspaceSlug}/projects/${parentIssue?.project_id}/issues/${parentIssue.id}`} target="_blank" onClick={handleParentIssueClick} > {/* ... */} </ControlLink>
📜 Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
📒 Files selected for processing (1)
- web/core/components/issues/issue-detail/parent/root.tsx (4 hunks)
🧰 Additional context used
🔇 Additional comments (3)
web/core/components/issues/issue-detail/parent/root.tsx (3)
9-9
: LGTM: New imports align with PR objectives.The addition of
ControlLink
and new hooks (useIssuePeekOverviewRedirection
,usePlatformOS
) are consistent with the PR's goal of opening parent issues in peek-overview. These imports set the foundation for the subsequent changes in the component.Also applies to: 12-13
33-34
: LGTM: New hooks enhance component functionality.The addition of
handleRedirection
fromuseIssuePeekOverviewRedirection
andisMobile
fromusePlatformOS
enhances the component's ability to handle navigation and adapt to different platforms. This is in line with the PR's objective of improving parent issue navigation.
Line range hint
1-85
: LGTM: Overall implementation is solid.The changes have been well-integrated into the existing component structure. The core logic for rendering issue details has been preserved, and the new functionality for handling parent issue navigation has been seamlessly added. The implementation maintains a good balance between the existing functionality and the new features.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We don't need target="_blank" on control link.
Issue link: WEB-2674
Summary by CodeRabbit
New Features
ControlLink
, for improved redirection to parent issue details.Bug Fixes
Documentation
IssueParentDetail
component.