Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: changed the annotate for cycle id #5892

Merged
merged 1 commit into from
Oct 22, 2024
Merged

Conversation

NarayanBavisetti
Copy link
Collaborator

@NarayanBavisetti NarayanBavisetti commented Oct 22, 2024

chore:

  • changed the annotate for cycle id

Summary by CodeRabbit

  • New Features

    • Enhanced issue management with improved cycle ID retrieval using subqueries.
    • Streamlined logic for fetching cycle IDs across various endpoints.
  • Bug Fixes

    • Maintained integrity of existing functionalities while optimizing data retrieval processes.
  • Documentation

    • Updated import statements to reflect changes in data handling methods.
  • Refactor

    • Replaced conditional logic with subquery-based approach for cycle ID annotations across multiple classes and methods.
  • Chores

    • Minor code formatting adjustments for improved readability.

Copy link
Contributor

coderabbitai bot commented Oct 22, 2024

Caution

Review failed

The pull request is closed.

Walkthrough

The changes primarily involve the introduction of a new model, CycleIssue, and the replacement of the existing logic for retrieving cycle_id across various API endpoints with a more efficient Subquery approach. This affects multiple files related to issue management, including views and models, ensuring that the cycle_id is fetched directly from the CycleIssue model where the issue matches and is not deleted. The overall functionality of creating, updating, and retrieving issues remains intact while enhancing the data retrieval process.

Changes

File Path Change Summary
apiserver/plane/api/views/issue.py Introduced CycleIssue model import; replaced Case and When logic with Subquery for cycle_id. Updated get_queryset methods to include cycle_id annotation.
apiserver/plane/app/views/cycle/issue.py Removed Case and When imports; updated get_queryset to use Subquery for cycle_id. Adjusted list method accordingly.
apiserver/plane/app/views/dashboard/base.py Updated cycle_id annotation in dashboard_assigned_issues and dashboard_created_issues functions to use Subquery.
apiserver/plane/app/views/inbox/base.py Updated InboxIssueViewSet to use Subquery for cycle_id in get_queryset and list methods. Refined create method for error handling.
apiserver/plane/app/views/issue/archive.py Updated get_queryset in IssueArchiveViewSet and BulkArchiveIssuesEndpoint to use Subquery for cycle_id.
apiserver/plane/app/views/issue/base.py Replaced Case with Subquery for cycle_id in IssueListEndpoint, IssueViewSet, and IssuePaginatedViewSet.
apiserver/plane/app/views/issue/relation.py Updated IssueRelationViewSet to use Subquery for cycle_id.
apiserver/plane/app/views/issue/sub_issue.py Updated SubIssuesEndpoint to use Subquery for cycle_id in get method.
apiserver/plane/app/views/module/issue.py Updated ModuleIssueViewSet to use Subquery for cycle_id in get_queryset.
apiserver/plane/app/views/view/base.py Updated WorkspaceViewIssuesViewSet to use Subquery for cycle_id in get_queryset and list methods.
apiserver/plane/app/views/workspace/draft.py Updated WorkspaceDraftIssueViewSet to use Subquery for cycle_id in get_queryset. Enhanced create_draft_to_issue method.
apiserver/plane/app/views/workspace/user.py Updated WorkspaceUserProfileIssuesEndpoint to use Subquery for cycle_id.
apiserver/plane/db/models/page.py Introduced new PageVersion class with fields for versioning pages. Added unique constraints to ProjectPage and TeamPage.
apiserver/plane/db/models/view.py Added filters, display_filters, and display_properties fields as JSON fields in IssueView. Updated save method logic.
apiserver/plane/space/views/issue.py Updated IssueRetrievePublicEndpoint to use Subquery for cycle_id.

Possibly related PRs

Suggested labels

⚙️backend, 🧹chore, 🔄migrations

Suggested reviewers

  • pablohashescobar
  • sriramveeraghanta

Poem

In the burrow where issues dwell,
Cycle IDs now ring a bell.
With Subquery swift and bright,
Our data flows with pure delight.
Hopping through code, we celebrate,
A cleaner path, oh, isn’t it great? 🐇✨


Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

❤️ Share
🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>, please review it.
    • Generate unit testing code for this file.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai generate unit testing code for this file.
    • @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
    • @coderabbitai read src/utils.ts and generate unit testing code.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
    • @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai full review to do a full review from scratch and review all the files again.
  • @coderabbitai summary to regenerate the summary of the PR.
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
  • @coderabbitai help to get help.

Other keywords and placeholders

  • Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
  • Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
  • Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

  • You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
  • Please see the configuration documentation for more information.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

@pushya22 pushya22 merged commit 295f094 into preview Oct 22, 2024
12 of 15 checks passed
@pushya22 pushya22 deleted the chore/cycle-annotate branch October 22, 2024 13:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants