[WEB-2781] fix: project view application error

[anmolsinghbhatia]

Changes:

This PR resolves an issue where clicking on “Project View” from a project with the view disabled resulted in an application error. Necessary updates have been made to fix this behavior.

Reference:

[WEB-2781]

Media:

Before	After

Summary by CodeRabbit

• Bug Fixes
  • Restored conditional checks for project identification and access permissions, improving error handling.
  • Added an EmptyState component to inform users when project views are disabled, with a link to project settings.

[coderabbitai]

Walkthrough

The changes in this pull request focus on the ProjectViewsPage component within the page.tsx file. Two conditional checks have been reintroduced: one to verify the presence of workspaceSlug and projectId, returning an empty fragment if either is falsy; the other checks the currentProjectDetails?.issue_views_view property, rendering an EmptyState component if it is false. These modifications restore essential error handling and control flow for managing access permissions and project identification.

Changes

File Path	Change Summary
web/app/[workspaceSlug]/(projects)/projects/(detail)/[projectId]/views/(list)/page.tsx	Reintroduced conditional checks for workspaceSlug and projectId; added rendering of EmptyState if issue_views_view is false.

Possibly related PRs

• [WEB-2443] fix: role validation and code refactor #5596: Enhances error handling in the ProjectViewIssuesPage component, relevant to the improvements in the ProjectViewsPage.
• [WEB-2682] fix: delete project mutation and workspace draft header validation #5843: Modifies the WorkspaceDraftHeader component to improve validation and functionality, aligning with the focus on correct behavior in the ProjectViewsPage.

Suggested reviewers

• sriramveeraghanta
• SatishGandham

🐰 In the meadow, changes bloom,
With checks restored, there's less gloom.
If views are false, we won't despair,
An empty state shows we still care.
So hop along, let's celebrate,
Project views are now first-rate! 🌼

---

Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

• Review comments: Directly reply to a review comment made by CodeRabbit. Example:
  • I pushed a fix in commit <commit_id>, please review it.
  • Generate unit testing code for this file.
  • Open a follow-up GitHub issue for this discussion.
• Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
  • @coderabbitai generate unit testing code for this file.
  • @coderabbitai modularize this function.
• PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
  • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
  • @coderabbitai read src/utils.ts and generate unit testing code.
  • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
  • @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

• @coderabbitai pause to pause the reviews on a PR.
• @coderabbitai resume to resume the paused reviews.
• @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
• @coderabbitai full review to do a full review from scratch and review all the files again.
• @coderabbitai summary to regenerate the summary of the PR.
• @coderabbitai resolve resolve all the CodeRabbit review comments.
• @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
• @coderabbitai help to get help.

Other keywords and placeholders

• Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
• Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
• Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

• You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
• Please see the configuration documentation for more information.
• If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

• Visit our Documentation for detailed information on how to use CodeRabbit.
• Join our Discord Community to get help, request features, and share feedback.
• Follow us on X/Twitter for updates and announcements.

[coderabbitai]

Actionable comments posted: 0

🧹 Outside diff range and nitpick comments (2)

web/app/[workspaceSlug]/(projects)/projects/(detail)/[projectId]/views/(list)/page.tsx (2)

52-52: Complete the TODO comment

The comment "No access to" appears to be incomplete. Consider updating it to clearly describe the access control check.

-  // No access to
+  // Check if project view access is disabled

---

53-61: LGTM: Proper error handling with clear user feedback

The implementation correctly handles the disabled view state and provides clear user feedback with a path to resolution. This effectively fixes the application error mentioned in WEB-2781.

Consider using null coalescing for a more robust check:

-  if (currentProjectDetails?.issue_views_view === false)
+  if ((currentProjectDetails?.issue_views_view ?? true) === false)

📜 Review details

Configuration used: CodeRabbit UI
Review profile: CHILL

📥 Commits

Reviewing files that changed from the base of the PR and between 1cb16bf and 2297f9b.

📒 Files selected for processing (1)

• web/app/[workspaceSlug]/(projects)/projects/(detail)/[projectId]/views/(list)/page.tsx (1 hunks)

🔇 Additional comments (1)

web/app/[workspaceSlug]/(projects)/projects/(detail)/[projectId]/views/(list)/page.tsx (1)

50-51: LGTM: Proper route parameter validation

The early return with an empty fragment when route parameters are missing is a good practice for preventing undefined behavior.