[WEB-2753]fix: intake issue activity #6185
Conversation
WalkthroughThe changes introduce a new case in the switch statement of the Changes
Possibly related PRs
Suggested reviewers
Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media? 🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
CodeRabbit Configuration File (
|
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
Actionable comments posted: 0
🧹 Outside diff range and nitpick comments (1)
web/core/components/issues/issue-detail/issue-activity/activity/activity-list.tsx (1)
Line range hint
85-89: Consider updating activity tracking documentationThe addition of "intake" as a new activity type follows the existing pattern. However, it would be beneficial to:
- Update any activity tracking documentation to include this new type
- Add comments explaining why "intake" and "inbox" activities share the same rendering component
📜 Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
📒 Files selected for processing (1)
web/core/components/issues/issue-detail/issue-activity/activity/activity-list.tsx(1 hunks)
🔇 Additional comments (2)
web/core/components/issues/issue-detail/issue-activity/activity/activity-list.tsx (2)
Line range hint 85-89: Implementation looks good!
The changes appropriately handle the intake activity rendering issue by reusing the IssueInboxActivity component. The implementation is clean and follows the existing pattern.
Please ensure that you've added test cases covering:
- Intake activity rendering
- Proper differentiation between intake and inbox activities
- Type activity rendering
Line range hint 85-89: Verify handling of intake and inbox activities
The implementation uses the same component (IssueInboxActivity) for both "intake" and "inbox" activities. While the fall-through case is a clean approach, we should verify that IssueInboxActivity can properly differentiate and handle both activity types.
✅ Verification successful
IssueInboxActivity correctly handles both intake and inbox activities
Looking at the search results, the IssueInboxActivity component in web/core/components/issues/issue-detail/issue-activity/activity/actions/inbox.tsx properly handles both intake and inbox activities. The component includes specific message handling for intake-related actions:
- "declined this issue from intake"
- "accepted this issue from intake"
- "declined this issue from intake by marking a duplicate issue"
- "updated intake issue status"
The fall-through case in the switch statement is appropriate as the same component is designed to handle both activity types with proper differentiation in the messaging.
🏁 Scripts executed
The following scripts were executed for the analysis:
Script:
#!/bin/bash
# Description: Verify IssueInboxActivity implementation handles both activity types
# Check if IssueInboxActivity handles different activity fields
ast-grep --pattern 'const IssueInboxActivity = $_($$$) => {
$$$
}'
# Search for any specific handling of intake vs inbox
rg -A 5 'intake|inbox' web/core/components/issues/issue-details/
Length of output: 219
Script:
#!/bin/bash
# Let's correct the path and try again with broader search
# Search for IssueInboxActivity component definition
ast-grep --pattern 'const IssueInboxActivity = $_($$$) => {
$$$
}'
# Search for IssueInboxActivity in the codebase
rg -A 5 "IssueInboxActivity"
# Search for intake/inbox activity handling
rg -A 5 'intake|inbox' web/core/components/issues/
Length of output: 6248
Description
Activity is not getting rendered when intake is moved to issues. Modified render component according to the payload.
Type of Change
References
WEB-2753
Summary by CodeRabbit