[WEB-3229] fix: issue creation from modal

[prateekshourya29]

Description

Type of Change

• Bug fix (non-breaking change which fixes an issue)
• Feature (non-breaking change which adds functionality)
• Improvement (change that would cause existing functionality to not work as expected)
• Code refactoring
• Performance improvements
• Documentation update

Screenshots and Media (if applicable)

Test Scenarios

References

Summary by CodeRabbit

• Bug Fixes
  • Improved issue modal handling by adding a fallback mechanism for store type selection
  • Ensured more consistent issue management when working with different store types

[coderabbitai]

Walkthrough

The pull request modifies the CreateUpdateIssueModalBase component in the web core issues modal, introducing a fallback mechanism for the storeType variable. When the store type is initially set to EEIssuesStoreType.EPIC, it is now automatically redirected to EEIssuesStoreType.PROJECT. This change adjusts the control flow for issue management within the modal, ensuring a more consistent store type handling.

Changes

File	Change Summary
web/core/components/issues/issue-modal/base.tsx	- Modified storeType declaration from const to let - Added conditional logic to default epic store type to project store type - Included clarifying comments for the new logic

Possibly related PRs

• [WEB-3172]fix: issue create in layouts. #6420: Simplifies assignment logic for storeType variable in the CreateUpdateIssueModalBase component

Suggested labels

🐛bug, 🌐frontend

Suggested reviewers

• sriramveeraghanta
• rahulramesha
• SatishGandham

Poem

🐰 In the realm of code, a rabbit's delight,
Where store types dance in modal's soft light,
From epic to project, a gentle slide,
Refactoring logic with a playful stride,
A small change blooms, both clever and bright! 🌟

---

📜 Recent review details

Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between e2550e0 and 0400195.

📒 Files selected for processing (1)

• web/core/components/issues/issue-modal/base.tsx (1 hunks)

⏰ Context from checks skipped due to timeout of 90000ms (1)

• GitHub Check: Analyze (javascript)

🔇 Additional comments (1)

web/core/components/issues/issue-modal/base.tsx (1)

45-49: Double-check fallback logic and ensure EPIC store type is not required elsewhere
Falling back from EPIC to PROJECT could mask legitimate scenarios where an EPIC store type is needed. Consider adding telemetry or logging here to trace unexpected scenarios and confirm that no other parts of the code specifically rely on the EPIC store type before it’s reset.

Below is an optional snippet to help track fallback occurrences:

 if (storeType === EIssuesStoreType.EPIC) {
+  console.warn("[issue-modal] storeType is EPIC, falling back to PROJECT store type.");
   storeType = EIssuesStoreType.PROJECT;
 }

✅ Verification successful

Fallback from EPIC to PROJECT store type is correct, add suggested logging

The fallback is an intentional safeguard ensuring proper issue creation in the modal context. The codebase shows that EPIC store type is properly handled where needed (views, filters, etc.) and explicitly avoided in the issue modal form. Adding the suggested logging will help track unexpected scenarios:

 if (storeType === EIssuesStoreType.EPIC) {
+  console.warn("[issue-modal] storeType is EPIC, falling back to PROJECT store type.");
   storeType = EIssuesStoreType.PROJECT;
 }

🏁 Scripts executed

The following scripts were executed for the analysis:

Error: No shell scripts found

---

Script:

#!/bin/bash
# Search for all occurrences of EPIC store type and related patterns
echo "=== Searching for EPIC store type usage ==="
rg "EIssuesStoreType\.EPIC" -A 2 -B 2

echo -e "\n=== Searching for store type related checks ==="
rg "storeType\s*===?\s*" -A 2 -B 2

echo -e "\n=== Looking for epic store implementations ==="
rg "epic.*store" -i --type ts --type tsx -A 2 -B 2

echo -e "\n=== Checking for the enum definition ==="
ast-grep --pattern 'enum EIssuesStoreType {
  $$$
}'

Length of output: 12446

---

Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

• Review comments: Directly reply to a review comment made by CodeRabbit. Example:
  • I pushed a fix in commit <commit_id>, please review it.
  • Generate unit testing code for this file.
  • Open a follow-up GitHub issue for this discussion.
• Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
  • @coderabbitai generate unit testing code for this file.
  • @coderabbitai modularize this function.
• PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
  • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
  • @coderabbitai read src/utils.ts and generate unit testing code.
  • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
  • @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

• @coderabbitai pause to pause the reviews on a PR.
• @coderabbitai resume to resume the paused reviews.
• @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
• @coderabbitai full review to do a full review from scratch and review all the files again.
• @coderabbitai summary to regenerate the summary of the PR.
• @coderabbitai generate docstrings to generate docstrings for this PR. (Beta)
• @coderabbitai resolve resolve all the CodeRabbit review comments.
• @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
• @coderabbitai help to get help.

Other keywords and placeholders

• Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
• Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
• Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

• You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
• Please see the configuration documentation for more information.
• If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

• Visit our Documentation for detailed information on how to use CodeRabbit.
• Join our Discord Community to get help, request features, and share feedback.
• Follow us on X/Twitter for updates and announcements.