Skip to content

Conversation

@aaryan610
Copy link
Member

@aaryan610 aaryan610 commented Jan 9, 2026

Description

This PR improves the settings interfaces across the app-

  1. Introduces a new modal for profile settings instead of the current separate route under workspace slug.
  2. Separates project and workspace settings into different layouts.
  3. Introduces new redirections-
    • profile/* -> settings/profile/*
    • :workspaceSlug/settings/account/* -> settings/profile/*

Type of Change

  • Improvement (change that would cause existing functionality to not work as expected)

Media

Profile settings-

Screen.Recording.2026-01-08.at.18.07.11.mov

@coderabbitai
Copy link
Contributor

coderabbitai bot commented Jan 9, 2026

Important

Review skipped

Too many files!

25 files out of 175 files are above the max files limit of 150.

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.


Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@makeplane
Copy link

makeplane bot commented Jan 9, 2026

Linked to Plane Work Item(s)

This comment was auto-generated by Plane

@aaryan610 aaryan610 changed the title [WEB-5860] style: improved workspace & project settings interface [WEB-5860] style: improved settings interfaces across the app Jan 15, 2026
@aaryan610 aaryan610 changed the title [WEB-5860] style: improved settings interfaces across the app [WEB-5860] [WEB-5861] [WEB-5862] style: improved profile settings interface Jan 15, 2026
@aaryan610 aaryan610 marked this pull request as ready for review January 15, 2026 13:21
Copilot AI review requested due to automatic review settings January 15, 2026 13:21
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This pull request modernizes the settings interface architecture by introducing a modal-based profile settings system and reorganizing workspace/project settings into dedicated layouts. The changes separate profile settings from workspace-specific routes and implement new URL patterns for better navigation.

Changes:

  • Introduced modal-based profile settings with new types and constants
  • Refactored workspace and project settings into separate sidebar layouts with categorized navigation
  • Implemented URL redirects from legacy routes (profile/*, :workspaceSlug/settings/account/*) to new paths (settings/profile/*)

Reviewed changes

Copilot reviewed 173 out of 175 changed files in this pull request and generated no comments.

Show a summary per file
File Description
packages/types/src/settings.ts New type definitions for profile, workspace, and project settings tabs and items
packages/constants/src/settings/* Reorganized constants into separate files for profile, workspace, and project settings with categorization
packages/ui/src/tables/table.tsx Updated table divider classes from divide-subtle-1 to divide-subtle
apps/web/core/store/base-command-palette.store.ts Added profile settings modal state management with activeTab and isOpen properties
apps/web/core/components/settings/* New unified settings components including sidebar items, control items, and content wrappers
apps/web/core/components/settings/profile/* New profile settings modal with sidebar and content pages for different tabs
apps/web/app/routes/redirects/core/* New redirect routes for legacy profile and account settings URLs
apps/web/app/(all)/settings/profile/* New profile settings route layout replacing old profile routes

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants